| Summary: | Gradient offsets are off if compositing operator != source-over | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||||
| Component: | Canvas | Assignee: | Nikos Andronikos <nikos.andronikos> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | blambov, buildbot, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kling, nikos.andronikos, rniwa, simon.fraser | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
Broken in Safari 7. Did this ever work? (In reply to comment #1) > Broken in Safari 7. Did this ever work? I don't know. Just created this example. Created attachment 228588 [details]
Patch
Comment on attachment 228588 [details] Patch Attachment 228588 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5548938127998976 New failing tests: transitions/cancel-transition.html Created attachment 228592 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
I looked at the test case. It seems very unlikely that this Canvas only thing (even limited to the context of the ImageBuffer) influences the transition test. This seems to be a false negative. Created attachment 228593 [details]
Same Patch for EWS
Comment on attachment 228593 [details] Same Patch for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=228593&action=review r=me > LayoutTests/ChangeLog:13 > + * fast/canvas/canvas-gradient-on-compositing.html: Added. > + * fast/canvas/script-tests/canvas-gradient-on-compositing.js: Added. I'd do this as a single file instead of the old-style js/html split. NABD. Comment on attachment 228593 [details] Same Patch for EWS Clearing flags on attachment: 228593 Committed r166785: <http://trac.webkit.org/changeset/166785> All reviewed patches have been landed. Closing bug. *** Bug 132949 has been marked as a duplicate of this bug. *** |
Created attachment 225966 [details] Example. Gradient should be in center of the canvas. The gradient offsets are off if compositing operator != source-over. It looks like the gradient space is not mapped to the canvas space correctly anymore.