Bug 129791

Summary:

Gradient offsets are off if compositing operator != source-over

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

Canvas

Assignee:

Nikos Andronikos <nikos.andronikos>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

blambov, buildbot, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kling, nikos.andronikos, rniwa, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Example. Gradient should be in center of the canvas.	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Same Patch for EWS	none

Dirk Schulze

Reported 2014-03-06 01:32:41 PST

Created attachment 225966 [details] Example. Gradient should be in center of the canvas. The gradient offsets are off if compositing operator != source-over. It looks like the gradient space is not mapped to the canvas space correctly anymore.

Attachments
Example. Gradient should be in center of the canvas. (851 bytes, text/html) 2014-03-06 01:32 PST, Dirk Schulze	no flags	Details
Patch (5.28 KB, patch) 2014-04-04 06:44 PDT, Dirk Schulze	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (492.06 KB, application/zip) 2014-04-04 08:05 PDT, Build Bot	no flags	Details
Same Patch for EWS (5.28 KB, patch) 2014-04-04 08:10 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2014-03-06 10:29:38 PST

Broken in Safari 7. Did this ever work?

Dirk Schulze

Comment 2 2014-03-06 12:01:02 PST

(In reply to comment #1) > Broken in Safari 7. Did this ever work? I don't know. Just created this example.

Dirk Schulze

Comment 3 2014-04-04 06:44:17 PDT

Created attachment 228588 [details] Patch

Build Bot

Comment 4 2014-04-04 08:05:37 PDT

Comment on attachment 228588 [details] Patch Attachment 228588 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5548938127998976 New failing tests: transitions/cancel-transition.html

Build Bot

Comment 5 2014-04-04 08:05:42 PDT

Created attachment 228592 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Dirk Schulze

Comment 6 2014-04-04 08:09:07 PDT

I looked at the test case. It seems very unlikely that this Canvas only thing (even limited to the context of the ImageBuffer) influences the transition test. This seems to be a false negative.

Dirk Schulze

Comment 7 2014-04-04 08:10:25 PDT

Created attachment 228593 [details] Same Patch for EWS

Andreas Kling

Comment 8 2014-04-04 09:11:03 PDT

Comment on attachment 228593 [details] Same Patch for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=228593&action=review r=me > LayoutTests/ChangeLog:13 > + * fast/canvas/canvas-gradient-on-compositing.html: Added. > + * fast/canvas/script-tests/canvas-gradient-on-compositing.js: Added. I'd do this as a single file instead of the old-style js/html split. NABD.

WebKit Commit Bot

Comment 9 2014-04-04 09:41:35 PDT

Comment on attachment 228593 [details] Same Patch for EWS Clearing flags on attachment: 228593 Committed r166785: <http://trac.webkit.org/changeset/166785>

WebKit Commit Bot

Comment 10 2014-04-04 09:41:41 PDT

All reviewed patches have been landed. Closing bug.

Nikos Andronikos

Comment 11 2014-07-24 17:23:06 PDT

*** Bug 132949 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.