Bug 129782

Summary: [GTK] [CMake] Clean up library linking
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, calvaris, cdumez, commit-queue, gyuyoung.kim, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Martin Robinson
Reported 2014-03-05 23:14:08 PST
We currently wrap -Wl,--whole-archive around some libraries to avoid dropping symbols from convenience libraries (libtool used to take care of this for us). Instead of doing that manually we can write a macro to do it for all libraries in a list. This also exposes some situations in which we are over-linking, linking in the same convenience library twice, or compiling the same files into multiple convenience libraries. We should clean all of that up.
Attachments
Patch (8.24 KB, patch)
2014-03-05 23:23 PST, Martin Robinson 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-03-05 23:23:52 PST
Created attachment 225955 [details] Patch
Martin Robinson
Comment 2 2014-03-10 10:05:31 PDT
Committed r165378: <http://trac.webkit.org/changeset/165378>
Note You need to log in before you can comment on or make changes to this bug.