Bug 129705

Summary: Allow iOS DumpRenderTree crashes to show application-specific information
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, mrowe, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ddkilzer: review+

Simon Fraser (smfr)
Reported 2014-03-04 14:22:04 PST
Allow iOS DumpRenderTree crashes to show application-specific information
Attachments
Patch (6.75 KB, patch)
2014-03-04 14:22 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (6.96 KB, patch)
2014-03-04 14:25 PST, Simon Fraser (smfr) 		ddkilzer: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-03-04 14:22:41 PST
Created attachment 225813 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-04 14:24:20 PST
Attachment 225813 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2014-03-04 14:25:32 PST
Created attachment 225814 [details] Patch
David Kilzer (:ddkilzer)
Comment 4 2014-03-04 14:35:23 PST
Comment on attachment 225814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225814&action=review r=me if you fix the WebCore.exp.in file. > Source/WebCore/WebCore.exp.in:2688 > +#if PLATFORM(MAC) || PLATFORM(IOS_SIMULATOR) > +_wkSetCrashReportApplicationSpecificInformation > +#endif This needs re-sorting. See Tools/Scripts/sort-export-file.
Simon Fraser (smfr)
Comment 5 2014-03-04 14:43:01 PST
https://trac.webkit.org/r165080
Note You need to log in before you can comment on or make changes to this bug.