| Summary: | Allow iOS DumpRenderTree crashes to show application-specific information | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ddkilzer, mrowe, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2014-03-04 14:22:04 PST
Created attachment 225813 [details]
Patch
Attachment 225813 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 225814 [details]
Patch
Comment on attachment 225814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225814&action=review r=me if you fix the WebCore.exp.in file. > Source/WebCore/WebCore.exp.in:2688 > +#if PLATFORM(MAC) || PLATFORM(IOS_SIMULATOR) > +_wkSetCrashReportApplicationSpecificInformation > +#endif This needs re-sorting. See Tools/Scripts/sort-export-file. |