Bug 129704

Summary: WKPage's pageExtendedBackgroundColor API exposed through WKView/WKWebView should support NSColor
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: WebKit APIAssignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Bug Depends on: 129120    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Conrad Shultz
Reported 2014-03-04 14:20:20 PST
WKPage's pageExtendedBackgroundColor API exposed through WKView/WKWebView should support NSColor
Attachments
Patch (4.33 KB, patch)
2014-03-04 14:31 PST, Conrad Shultz 		no flags
DetailsFormatted DiffDiff
Patch (4.34 KB, patch)
2014-03-04 15:15 PST, Conrad Shultz 		no flags
DetailsFormatted DiffDiff
Patch (4.23 KB, patch)
2014-03-04 15:48 PST, Conrad Shultz 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Conrad Shultz
Comment 1 2014-03-04 14:31:20 PST
Created attachment 225816 [details] Patch
Conrad Shultz
Comment 2 2014-03-04 15:08:49 PST
Comment on attachment 225816 [details] Patch Copy/paste error; will repost.
Conrad Shultz
Comment 3 2014-03-04 15:15:33 PST
Created attachment 225821 [details] Patch
Beth Dakin
Comment 4 2014-03-04 15:31:27 PST
Comment on attachment 225821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225821&action=review r=me, but you should simplify those return statements with nsColor(). > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:852 > + return [NSColor colorWithDeviceRed:(color.red() / 255.0) green:(color.green() / 255.0) blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)]; You can actually use the convenient nsColor() here, just like in the underlayColor method in the same class. return nsColor(color); > Source/WebKit2/UIProcess/API/mac/WKView.mm:3269 > + return [NSColor colorWithDeviceRed:(color.red() / 255.0) green:(color.green() / 255.0) blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)]; Similarly, you can use nsColor() here I think.
Conrad Shultz
Comment 5 2014-03-04 15:48:36 PST
Created attachment 225826 [details] Patch
WebKit Commit Bot
Comment 6 2014-03-04 16:21:14 PST
Comment on attachment 225826 [details] Patch Clearing flags on attachment: 225826 Committed r165083: <http://trac.webkit.org/changeset/165083>
WebKit Commit Bot
Comment 7 2014-03-04 16:21:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.