Bug 129704 – WKPage's pageExtendedBackgroundColor API exposed through WKView/WKWebView should support NSColor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Conrad Shultz]

WKPage's pageExtendedBackgroundColor API exposed through WKView/WKWebView should support NSColor

[Conrad Shultz]

Created attachment 225816 [details]
Patch

[Conrad Shultz]

Comment on attachment 225816 [details]
Patch

Copy/paste error; will repost.

[Conrad Shultz]

Created attachment 225821 [details]
Patch

[Beth Dakin]

Comment on attachment 225821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225821&action=review

r=me, but you should simplify those return statements with nsColor().

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:852
> +    return [NSColor colorWithDeviceRed:(color.red() / 255.0) green:(color.green() / 255.0) blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)];

You can actually use the convenient nsColor() here, just like in the underlayColor method in the same class.

return nsColor(color);

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3269
> +    return [NSColor colorWithDeviceRed:(color.red() / 255.0) green:(color.green() / 255.0) blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)];

Similarly, you can use nsColor() here I think.

[Conrad Shultz]

Created attachment 225826 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 225826 [details]
Patch

Clearing flags on attachment: 225826

Committed r165083: <http://trac.webkit.org/changeset/165083>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.