Bug 129673

Summary: Micro-optimize Strings in JS bindings.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Description Andreas Kling 2014-03-04 01:46:07 PST 
Micro-optimize Strings in JS bindings.
Comment 1 Andreas Kling 2014-03-04 01:49:40 PST 
Created attachment 225762 [details]
Patch
Comment 2 Andreas Kling 2014-03-04 01:57:43 PST 
Comment on attachment 225762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review

> Source/JavaScriptCore/runtime/JSString.h:419
> +        // Should have picked a global empty or single-character string already.

s/global/VM-global/
Comment 3 Ryosuke Niwa 2014-03-04 02:05:08 PST 
Comment on attachment 225762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review

> Source/WebCore/bindings/js/JSDOMBinding.h:597
> +    return JSC::jsStringWithWeakOwner(vm, *s.impl());

Why don't we use *stringImpl instead?
Comment 4 Andreas Kling 2014-03-04 08:59:45 PST 
Committed r165054: <http://trac.webkit.org/changeset/165054>