Bug 129673

Summary:

Micro-optimize Strings in JS bindings.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore JavaScript

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, kling, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

Andreas Kling

Reported 2014-03-04 01:46:07 PST

Micro-optimize Strings in JS bindings.

Attachments
Patch (4.68 KB, patch) 2014-03-04 01:49 PST, Andreas Kling	rniwa: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2014-03-04 01:49:40 PST

Andreas Kling

Comment 2 2014-03-04 01:57:43 PST

Comment on attachment 225762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review > Source/JavaScriptCore/runtime/JSString.h:419 > + // Should have picked a global empty or single-character string already. s/global/VM-global/

Ryosuke Niwa

Comment 3 2014-03-04 02:05:08 PST

Comment on attachment 225762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review > Source/WebCore/bindings/js/JSDOMBinding.h:597 > + return JSC::jsStringWithWeakOwner(vm, *s.impl()); Why don't we use *stringImpl instead?

Andreas Kling

Comment 4 2014-03-04 08:59:45 PST

Note You need to log in before you can comment on or make changes to this bug.