| Summary: | [GTK][WK1] Add load-error-with-tls-errors signal to WebKitWebView | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Boeckel <mathstuf> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED WONTFIX | ||||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, gustavo, mrobinson, zan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 129653 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Ben Boeckel
2014-03-03 20:04:48 PST
Created attachment 225733 [details]
Patch
Attachment 225733 [details] did not pass style-queue:
Total errors found: 0 in 0 files
If any of these errors are false positives, please file a bug against check-webkit-style.
During what signal is the SoupMessage null? "load-error". When asking for it, the WebKitNetworkResponse is constructed with the "uri" property rather than the "message" property in kitNew. Created attachment 225859 [details]
Add-load-error-with-tls-errors-to-WebKit1
Actual patch rather than the empty file uploaded by "Tools/Scripts/webkit-patch attach-to-bug -g HEAD -m Patch 129654 WK1-TLS-error-signal.patch".
I'm guessing CMake needs to be updated for the new files as well (btw, is there a timeline for using CMake as the official build system?). Heh, (In reply to comment #6) > (btw, is there a timeline for using CMake as the official build system?). ...and perfect timing with the latest ML post. WebKit1GTK+ has been removed. Comment on attachment 225859 [details] Add-load-error-with-tls-errors-to-WebKit1 Cleared review? from attachment 225859 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |