Bug 129654

Summary: [GTK][WK1] Add load-error-with-tls-errors signal to WebKitWebView
Product: WebKit Reporter: Ben Boeckel <mathstuf>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cgarcia, commit-queue, gustavo, mrobinson, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 129653    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Add-load-error-with-tls-errors-to-WebKit1 none

Ben Boeckel
Reported 2014-03-03 20:04:48 PST
Matches the WK2 signal. This is necessary because the WebKitWebFrame's WebKitNetworkResponse has a NULL SoupMessage (where I had expected to find the actual error).
Attachments
Patch (26 bytes, patch)
2014-03-03 20:14 PST, Ben Boeckel 		no flags
DetailsFormatted DiffDiff
Add-load-error-with-tls-errors-to-WebKit1 (15.52 KB, patch)
2014-03-04 22:40 PST, Ben Boeckel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ben Boeckel
Comment 1 2014-03-03 20:14:07 PST
Created attachment 225733 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-03 20:36:20 PST
Attachment 225733 [details] did not pass style-queue: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 3 2014-03-04 08:27:17 PST
During what signal is the SoupMessage null?
Ben Boeckel
Comment 4 2014-03-04 08:33:41 PST
"load-error". When asking for it, the WebKitNetworkResponse is constructed with the "uri" property rather than the "message" property in kitNew.
Ben Boeckel
Comment 5 2014-03-04 22:40:50 PST
Created attachment 225859 [details] Add-load-error-with-tls-errors-to-WebKit1 Actual patch rather than the empty file uploaded by "Tools/Scripts/webkit-patch attach-to-bug -g HEAD -m Patch 129654 WK1-TLS-error-signal.patch".
Ben Boeckel
Comment 6 2014-03-05 15:00:48 PST
I'm guessing CMake needs to be updated for the new files as well (btw, is there a timeline for using CMake as the official build system?).
Ben Boeckel
Comment 7 2014-03-05 21:07:18 PST
Heh, (In reply to comment #6) > (btw, is there a timeline for using CMake as the official build system?). ...and perfect timing with the latest ML post.
Martin Robinson
Comment 8 2014-04-08 17:47:12 PDT
WebKit1GTK+ has been removed.
Csaba Osztrogonác
Comment 9 2014-06-04 00:50:56 PDT
Comment on attachment 225859 [details] Add-load-error-with-tls-errors-to-WebKit1 Cleared review? from attachment 225859 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.