Summary: | [CSS Shapes] Add performance tests for Shapes with Regions | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||||||||||||
Component: | CSS | Assignee: | Zoltan Horvath <zoltan> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | benjamin, commit-queue, dino, kling, koivisto, rniwa, simon.fraser | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 128188 | ||||||||||||||||
Attachments: |
|
Description
Zoltan Horvath
2014-03-03 14:50:31 PST
Created attachment 225692 [details]
Patch
Could you attach the page here so that we can see what it looks like? Created attachment 225954 [details]
screenshot
The content flows into the region-flow 3 times, the last couple of regions are simple window size boxes. The first 3 columns adopts (reduces to 2 and 1 column) to the actual page size with the help of media queries. Each shape is defined by a different way. The test showed up a bug float flowing bug with regions, I reported it separately.
If you like this for testing, I'm gonna introduce the same page region-/shapeless versions under Shape, so it can run locally if someone wants to test them.
Comment on attachment 225692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225692&action=review > PerformanceTests/Layout/RegionsShapes.html:15 > + iframe.style.width = '100%'; I don't think we want to use 100% because then the performance will be dependent on how wide your window is. Created attachment 226339 [details]
Patch
I modified it to use fix size.
Created attachment 226342 [details]
Patch
Modified the size to keep good friendship with DumpRenderTree's default width.
r? Comment on attachment 226342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226342&action=review > PerformanceTests/Layout/RegionsShapes.html:15 > + iframe.style.width = '800px'; 800px wouldn't work unless we set padding/margin on html/body to 0. Created attachment 228063 [details]
Patch for landing
Created attachment 228064 [details]
Patch for landing
Comment on attachment 228064 [details] Patch for landing Clearing flags on attachment: 228064 Committed r166416: <http://trac.webkit.org/changeset/166416> All reviewed patches have been landed. Closing bug. |