Bug 129611

Summary: ScriptExecutionContext::vm() should return a reference.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ggaren: review+
Patch
commit-queue: commit-queue-
Geoffrey none

Andreas Kling
Reported 2014-03-03 10:20:01 PST
ScriptExecutionContext::vm() should return a reference.
Attachments
Patch (8.61 KB, patch)
2014-03-03 10:20 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (7.88 KB, patch)
2014-03-03 10:30 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (8.51 KB, patch)
2014-03-03 11:07 PST, Andreas Kling 		ggaren: review+
DetailsFormatted DiffDiff
Patch (10.10 KB, patch)
2014-03-16 12:28 PDT, Andreas Kling 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Geoffrey (10.10 KB, patch)
2014-03-16 12:42 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-03-03 10:20:25 PST
Created attachment 225666 [details] Patch
Andreas Kling
Comment 2 2014-03-03 10:30:50 PST
Created attachment 225668 [details] Patch
Andreas Kling
Comment 3 2014-03-03 11:07:57 PST
Created attachment 225673 [details] Patch
Geoffrey Garen
Comment 4 2014-03-03 13:36:27 PST
Comment on attachment 225673 [details] Patch r=me Please fix Windows build.
Andreas Kling
Comment 5 2014-03-16 12:28:46 PDT
Created attachment 226851 [details] Patch
WebKit Commit Bot
Comment 6 2014-03-16 12:29:49 PDT
Comment on attachment 226851 [details] Patch Rejecting attachment 226851 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226851, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Geoff Garen found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/6737959357251584
Andreas Kling
Comment 7 2014-03-16 12:42:41 PDT
Created attachment 226852 [details] Geoffrey
WebKit Commit Bot
Comment 8 2014-03-16 13:21:34 PDT
Comment on attachment 226852 [details] Geoffrey Clearing flags on attachment: 226852 Committed r165710: <http://trac.webkit.org/changeset/165710>
WebKit Commit Bot
Comment 9 2014-03-16 13:21:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.