| Summary: | ScriptExecutionContext::vm() should return a reference. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||
| Component: | WebCore JavaScript | Assignee: | Andreas Kling <kling> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | allan.jensen, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, macpherson, menard | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Andreas Kling
2014-03-03 10:20:01 PST
Created attachment 225666 [details]
Patch
Created attachment 225668 [details]
Patch
Created attachment 225673 [details]
Patch
Comment on attachment 225673 [details]
Patch
r=me
Please fix Windows build.
Created attachment 226851 [details]
Patch
Comment on attachment 226851 [details] Patch Rejecting attachment 226851 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226851, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Geoff Garen found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/6737959357251584 Created attachment 226852 [details]
Geoffrey
Comment on attachment 226852 [details] Geoffrey Clearing flags on attachment: 226852 Committed r165710: <http://trac.webkit.org/changeset/165710> All reviewed patches have been landed. Closing bug. |