Summary: | CodeBlock::hasDebuggerRequests() should returning a bool instead of an int | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2014-03-02 15:01:31 PST
Created attachment 225613 [details]
the patch.
Comment on attachment 225613 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=225613&action=review > Source/JavaScriptCore/bytecode/CodeBlock.h:880 > + bool hasDebuggerRequests() const { return !!m_debuggerRequests; } By the way, there is no need for the !! here. That was only needed in compilers that lacked bool support, but we don’t compile WebKit with those kinds of old compilers. Comment on attachment 225613 [details] the patch. Clearing flags on attachment: 225613 Committed r164954: <http://trac.webkit.org/changeset/164954> All reviewed patches have been landed. Closing bug. |