Bug 129569

Summary: Make Length functions take viewport size instead of RenderView*
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jcraig, jdiggs, kangil.han, kling, kondapallykalyan, macpherson, mario, menard, pdr, samuel_white, schenney, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2014-03-01 19:15:06 PST
int minimumIntValueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0, bool roundPercentages = false); int intValueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0, bool roundPercentages = false); LayoutUnit minimumValueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0, bool roundPercentages = false); LayoutUnit valueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0, bool roundPercentages = false); float floatValueForLength(const Length&, LayoutUnit maximumValue, RenderView* = 0); float floatValueForLength(const Length&, float maximumValue, RenderView* = 0);
Attachments
Patch (70.80 KB, patch)
2014-03-01 19:32 PST, alan
no flags
Patch (71.73 KB, patch)
2014-03-01 20:12 PST, alan
no flags
Patch (71.94 KB, patch)
2014-03-01 20:57 PST, alan
no flags
alan
Comment 1 2014-03-01 19:32:22 PST
alan
Comment 2 2014-03-01 20:12:39 PST
alan
Comment 3 2014-03-01 20:12:58 PST
Comment on attachment 225585 [details] Patch EWS testing
alan
Comment 4 2014-03-01 20:57:46 PST
alan
Comment 5 2014-03-01 20:57:57 PST
Comment on attachment 225588 [details] Patch EWS
alan
Comment 6 2014-03-08 16:26:47 PST
viewportSize() call can still be a bit expensive on some platforms. WebKit is not ready for this change yet.
Note You need to log in before you can comment on or make changes to this bug.