Bug 129557

Summary: Subpixel rendering: Make GraphicsLayer::fillRect FloatRoundedRect based and cleanup dependencies.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, d-r, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, jonlee, kondapallykalyan, philipj, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 129558    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2014-03-01 13:49:59 PST
Merge FloatRect + Radii parameters to FloatRoundedRect.
Attachments
Patch (45.85 KB, patch)
2014-03-01 14:36 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (49.03 KB, patch)
2014-03-01 20:02 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (55.08 KB, patch)
2014-03-01 20:54 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (55.77 KB, patch)
2014-03-01 21:32 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (76.42 KB, patch)
2014-03-02 19:41 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (78.86 KB, patch)
2014-03-03 08:52 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (79.37 KB, patch)
2014-03-03 12:15 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (80.07 KB, patch)
2014-03-04 07:38 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2014-03-01 14:36:10 PST
Created attachment 225568 [details] Patch
alan
Comment 2 2014-03-01 20:02:30 PST
Created attachment 225583 [details] Patch
alan
Comment 3 2014-03-01 20:02:52 PST
Comment on attachment 225583 [details] Patch EWS testing
alan
Comment 4 2014-03-01 20:54:42 PST
Created attachment 225587 [details] Patch
alan
Comment 5 2014-03-01 20:55:01 PST
Comment on attachment 225587 [details] Patch EWS
alan
Comment 6 2014-03-01 21:32:08 PST
Created attachment 225589 [details] Patch
alan
Comment 7 2014-03-01 21:32:30 PST
Comment on attachment 225589 [details] Patch EWS win testing
alan
Comment 8 2014-03-02 19:41:34 PST
Created attachment 225629 [details] Patch
alan
Comment 9 2014-03-02 19:42:01 PST
Comment on attachment 225629 [details] Patch updated patch. ews.
alan
Comment 10 2014-03-03 08:52:56 PST
Created attachment 225658 [details] Patch
alan
Comment 11 2014-03-03 08:53:12 PST
Comment on attachment 225658 [details] Patch EWS win.
alan
Comment 12 2014-03-03 12:15:40 PST
Created attachment 225682 [details] Patch
alan
Comment 13 2014-03-03 12:15:57 PST
Comment on attachment 225682 [details] Patch EWS win.
Simon Fraser (smfr)
Comment 14 2014-03-03 16:12:15 PST
Comment on attachment 225682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225682&action=review > Source/WebCore/platform/graphics/FloatRoundedRect.cpp:151 > + && m_radii.bottomLeft().width() + m_radii.bottomRight().width() <= m_rect.width() > + && m_radii.topLeft().height() + m_radii.bottomLeft().height() <= m_rect.height() > + && m_radii.topRight().height() + m_radii.bottomRight().height() <= m_rect.height(); Indent these lines. > Source/WebCore/platform/graphics/Path.cpp:135 > + if (rect.width() < radii.topLeft().width() + radii.topRight().width() > + || rect.width() < radii.bottomLeft().width() + radii.bottomRight().width() > + || rect.height() < radii.topLeft().height() + radii.bottomLeft().height() > + || rect.height() < radii.topRight().height() + radii.bottomRight().height()) { > // If all the radii cannot be accommodated, return a rect. Is this the same logic as isRenderable?
alan
Comment 15 2014-03-04 07:38:23 PST
Created attachment 225777 [details] Patch
alan
Comment 16 2014-03-04 07:38:56 PST
Comment on attachment 225777 [details] Patch EWS testing before commit.
alan
Comment 17 2014-03-04 07:44:09 PST
(In reply to comment #14) > (From update of attachment 225682 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225682&action=review > > > Source/WebCore/platform/graphics/FloatRoundedRect.cpp:151 > > + && m_radii.bottomLeft().width() + m_radii.bottomRight().width() <= m_rect.width() > > + && m_radii.topLeft().height() + m_radii.bottomLeft().height() <= m_rect.height() > > + && m_radii.topRight().height() + m_radii.bottomRight().height() <= m_rect.height(); > > Indent these lines. Done. > > > Source/WebCore/platform/graphics/Path.cpp:135 > > + if (rect.width() < radii.topLeft().width() + radii.topRight().width() > > + || rect.width() < radii.bottomLeft().width() + radii.bottomRight().width() > > + || rect.height() < radii.topLeft().height() + radii.bottomLeft().height() > > + || rect.height() < radii.topRight().height() + radii.bottomRight().height()) { > > // If all the radii cannot be accommodated, return a rect. > > Is this the same logic as isRenderable? Yes. Fixed.
WebKit Commit Bot
Comment 18 2014-03-04 09:01:11 PST
Comment on attachment 225777 [details] Patch Clearing flags on attachment: 225777 Committed r165055: <http://trac.webkit.org/changeset/165055>
WebKit Commit Bot
Comment 19 2014-03-04 09:01:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.