Summary: | Subpixel rendering: Make GraphicsLayer::fillRect FloatRoundedRect based and cleanup dependencies. | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, d-r, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, jonlee, kondapallykalyan, philipj, sergio, simon.fraser | ||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||
Bug Blocks: | 129558 | ||||||||||||||||||||
Attachments: |
|
Description
zalan
2014-03-01 13:49:59 PST
Created attachment 225568 [details]
Patch
Created attachment 225583 [details]
Patch
Comment on attachment 225583 [details]
Patch
EWS testing
Created attachment 225587 [details]
Patch
Comment on attachment 225587 [details]
Patch
EWS
Created attachment 225589 [details]
Patch
Comment on attachment 225589 [details]
Patch
EWS win testing
Created attachment 225629 [details]
Patch
Comment on attachment 225629 [details]
Patch
updated patch. ews.
Created attachment 225658 [details]
Patch
Comment on attachment 225658 [details]
Patch
EWS win.
Created attachment 225682 [details]
Patch
Comment on attachment 225682 [details]
Patch
EWS win.
Comment on attachment 225682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225682&action=review > Source/WebCore/platform/graphics/FloatRoundedRect.cpp:151 > + && m_radii.bottomLeft().width() + m_radii.bottomRight().width() <= m_rect.width() > + && m_radii.topLeft().height() + m_radii.bottomLeft().height() <= m_rect.height() > + && m_radii.topRight().height() + m_radii.bottomRight().height() <= m_rect.height(); Indent these lines. > Source/WebCore/platform/graphics/Path.cpp:135 > + if (rect.width() < radii.topLeft().width() + radii.topRight().width() > + || rect.width() < radii.bottomLeft().width() + radii.bottomRight().width() > + || rect.height() < radii.topLeft().height() + radii.bottomLeft().height() > + || rect.height() < radii.topRight().height() + radii.bottomRight().height()) { > // If all the radii cannot be accommodated, return a rect. Is this the same logic as isRenderable? Created attachment 225777 [details]
Patch
Comment on attachment 225777 [details]
Patch
EWS testing before commit.
(In reply to comment #14) > (From update of attachment 225682 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225682&action=review > > > Source/WebCore/platform/graphics/FloatRoundedRect.cpp:151 > > + && m_radii.bottomLeft().width() + m_radii.bottomRight().width() <= m_rect.width() > > + && m_radii.topLeft().height() + m_radii.bottomLeft().height() <= m_rect.height() > > + && m_radii.topRight().height() + m_radii.bottomRight().height() <= m_rect.height(); > > Indent these lines. Done. > > > Source/WebCore/platform/graphics/Path.cpp:135 > > + if (rect.width() < radii.topLeft().width() + radii.topRight().width() > > + || rect.width() < radii.bottomLeft().width() + radii.bottomRight().width() > > + || rect.height() < radii.topLeft().height() + radii.bottomLeft().height() > > + || rect.height() < radii.topRight().height() + radii.bottomRight().height()) { > > // If all the radii cannot be accommodated, return a rect. > > Is this the same logic as isRenderable? Yes. Fixed. Comment on attachment 225777 [details] Patch Clearing flags on attachment: 225777 Committed r165055: <http://trac.webkit.org/changeset/165055> All reviewed patches have been landed. Closing bug. |