Bug 129501

Summary:

[Mac, iOS] Incorrect ordering of construction arguments for out-of-band text elements

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Media

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+

Description Brent Fulgham 2014-02-28 11:52:59 PST

I made a mistake in the order of arguments passed to the new "createOutOfBand" constructor for the PlatformTextTrack in HTMLMediaElement::outOfBandTrackSources. The label and source URLs were reversed.

This patch corrects that mistake so that the NSDictionary of items passed to AVFoundation is correct.

Comment 1 Radar WebKit Bug Importer 2014-02-28 11:53:32 PST

<rdar://problem/16198587>

Comment 2 Brent Fulgham 2014-02-28 12:04:19 PST

Created attachment 225479 [details]
Patch

Comment 3 Brent Fulgham 2014-02-28 13:07:25 PST

Committed r164881: <http://trac.webkit.org/changeset/164881>