Summary: | REGRESSION (r164804): svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html frequently crashes | ||
---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
Component: | SVG | Assignee: | Antoine Quint <graouts> |
Status: | RESOLVED WORKSFORME | ||
Severity: | Normal | CC: | graouts, graouts, zimmermann |
Priority: | P2 | Keywords: | MakingBotsRed, Regression |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Alexey Proskuryakov
2014-02-28 11:11:26 PST
svg/as-background-image/background-image-preserveaspectRatio-support.html too. I'm not managing to reproduce this on Mavericks running `Tools/Scripts/run-webkit-tests --debug svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html`. Always passes. Will it reproduce for you with this invocation? I didn't try myself, as I'm still on an earlier revision. Tools/Scripts/run-webkit-tests --debug -2 --repeat-each 1000 svg/zoom/page/zoom-img-preserveAspectRatio-support.html svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html (In reply to comment #3) > Will it reproduce for you with this invocation? I didn't try myself, as I'm still on an earlier revision. > > Tools/Scripts/run-webkit-tests --debug -2 --repeat-each 1000 svg/zoom/page/zoom-img-preserveAspectRatio-support.html svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html In this case I do very rare crashes. I think the crash is coming from a NULL frame when we call this line in FrameView::scrollToFragment(): if (!url.hasFragmentIdentifier() && !frame().document()->cssTarget()) What's the next step here? Does r164804 need to be rolled out? It's important to make the bots green again ASAP, as existing failures make it much more difficult to spot future unrelated regressions. (In reply to comment #5) > What's the next step here? Does r164804 need to be rolled out? > > It's important to make the bots green again ASAP, as existing failures make it much more difficult to spot future unrelated regressions. We're tracking a slightly different approach to fix https://bugs.webkit.org/show_bug.cgi?id=129387 which would also prevent this crash. I hope to have a revised patch out tomorrow at the latest, but I can't promise when it'd be get in the tree. (In reply to comment #6) > (In reply to comment #5) > > What's the next step here? Does r164804 need to be rolled out? > > > > It's important to make the bots green again ASAP, as existing failures make it much more difficult to spot future unrelated regressions. > > We're tracking a slightly different approach to fix https://bugs.webkit.org/show_bug.cgi?id=129387 which would also prevent this crash. I hope to have a revised patch out tomorrow at the latest, but I can't promise when it'd be get in the tree. Patch that should prevent this crash is now attached to https://bugs.webkit.org/show_bug.cgi?id=129387.z Hopefully, https://trac.webkit.org/r164983 fixes this flakiness. Thank you! I'll re-open if I see this happen again. |