Bug 129463

Summary:

Web Inspector: Use a RegExp when when using CodeMirror SearchCursor

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Timothy Hatcher

Reported 2014-02-27 16:35:56 PST

When passing a string to CodeMirror.getSearchCursor, and doing a case-insensitive search, CodeMirror will do toLowerString() on each line. That is expensive. Use a case-insensitive RegExp instead.

Attachments
Patch (1.84 KB, patch) 2014-02-27 16:38 PST, Timothy Hatcher	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-02-27 16:36:08 PST

<rdar://problem/16190839>

Timothy Hatcher

Comment 2 2014-02-27 16:38:50 PST

Created attachment 225429 [details] Patch

Joseph Pecoraro

Comment 3 2014-02-27 16:39:53 PST

Comment on attachment 225429 [details] Patch r=me

WebKit Commit Bot

Comment 4 2014-02-27 17:13:24 PST

Comment on attachment 225429 [details] Patch Clearing flags on attachment: 225429 Committed r164846: <http://trac.webkit.org/changeset/164846>

WebKit Commit Bot

Comment 5 2014-02-27 17:13:26 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.