Bug 129456

Summary:

Crash in RemoteLayerTreePropertyApplier::applyPropertiesToLayer

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jonlee, sam, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	simon.fraser: review+

Description Tim Horton 2014-02-27 15:52:59 PST

<rdar://problem/16182676>

Seeing a crash in RemoteLayerTreePropertyApplier::applyPropertiesToLayer when going from having layer contents to not having layer contents. We're dereferencing the RemoteLayerBacking without checking if it exists, in the accelerated drawing codepath.

Also, this #if structure is disturbing (conditional control flow scares me), so rework it a bit.

Comment 1 Tim Horton 2014-02-27 15:55:11 PST

Created attachment 225421 [details]
patch

Comment 2 Tim Horton 2014-02-27 15:56:36 PST

Comment on attachment 225421 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225421&action=review

> Source/WebKit2/ChangeLog:11
> +        We were dereferencing the RemoteLayerBacking without checking if it exists,

+Store

Comment 3 Tim Horton 2014-02-27 15:59:04 PST

http://trac.webkit.org/changeset/164840