Bug 129454

Summary:

Slow cases for function.apply and function.call should not require vm re-entry

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

129488

Bug Blocks:

Attachments:

Description	Flags
Patch	ggaren: review+

Description Oliver Hunt 2014-02-27 14:52:47 PST

Slow cases for function.apply and function.call should not require vm re-entry

Comment 1 Oliver Hunt 2014-02-27 14:55:41 PST

Created attachment 225415 [details]
Patch

Comment 2 Geoffrey Garen 2014-02-27 15:09:37 PST

Comment on attachment 225415 [details]
Patch

r=me

Seems like a js-regress test is in order, in which someone aliases .call or .apply.

Comment 3 Oliver Hunt 2014-02-27 15:19:56 PST

Committed r164835: <http://trac.webkit.org/changeset/164835>

Comment 4 Csaba Osztrogonác 2014-02-28 08:42:05 PST

(In reply to comment #3)
> Committed r164835: <http://trac.webkit.org/changeset/164835>

It caused regression on 32 bit, see https://bugs.webkit.org/show_bug.cgi?id=129488 for details.