Bug 129436

Summary: [Mac][WK2] Remove hardcoded Cmd+B and Cmd+I from WKView.mm
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: HTML EditingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, enrica, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2014-02-27 10:11:22 PST
We hardcode Cmd+B and Cmd+I in WebKit1 for historic reasons, but it doesn't look like there is any need to do this in WebKit2. I tested GMail and iCloud e-mail, and these shortcuts work there even without this code (presumably because both implemented them in JS for Firefox on Mac). Mail.app has these shortcuts in menu, so again, hardcoding is unnecessary. The reason I want to remove this is that _handleStyleKeyEquivalent looks at EditorState, which is not going to be supported in the future.
Attachments
proposed patch (2.33 KB, patch)
2014-02-27 10:13 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-02-27 10:13:11 PST
Created attachment 225387 [details] proposed patch
WebKit Commit Bot
Comment 2 2014-02-27 11:14:37 PST
Comment on attachment 225387 [details] proposed patch Clearing flags on attachment: 225387 Committed r164818: <http://trac.webkit.org/changeset/164818>
WebKit Commit Bot
Comment 3 2014-02-27 11:14:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.