Bug 129436

Summary:

[Mac][WK2] Remove hardcoded Cmd+B and Cmd+I from WKView.mm

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

HTML Editing

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, enrica, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Description Alexey Proskuryakov 2014-02-27 10:11:22 PST

We hardcode Cmd+B and Cmd+I in WebKit1 for historic reasons, but it doesn't look like there is any need to do this in WebKit2.

I tested GMail and iCloud e-mail, and these shortcuts work there even without this code (presumably because both implemented them in JS for Firefox on Mac). Mail.app has these shortcuts in menu, so again, hardcoding is unnecessary.

The reason I want to remove this is that _handleStyleKeyEquivalent looks at EditorState, which is not going to be supported in the future.

Comment 1 Alexey Proskuryakov 2014-02-27 10:13:11 PST

Created attachment 225387 [details]
proposed patch

Comment 2 WebKit Commit Bot 2014-02-27 11:14:37 PST

Comment on attachment 225387 [details]
proposed patch

Clearing flags on attachment: 225387

Committed r164818: <http://trac.webkit.org/changeset/164818>

Comment 3 WebKit Commit Bot 2014-02-27 11:14:39 PST

All reviewed patches have been landed.  Closing bug.