Bug 129415

Summary: r164764 broke the ARM build
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, rgabor, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Patch
none
Patch
none
proposed fix none

Description Mark Hahnenberg 2014-02-26 18:17:44 PST 
Potential fix coming.
Comment 1 Mark Hahnenberg 2014-02-26 18:19:27 PST 
Created attachment 225335 [details]
Patch
Comment 2 Mark Hahnenberg 2014-02-26 18:20:00 PST 
(In reply to comment #1)
> Created an attachment (id=225335) [details]
> Patch

Potential fix. I don't have a way to test this patch.
Comment 3 Geoffrey Garen 2014-02-26 19:04:54 PST 
Comment on attachment 225335 [details]
Patch

Is this just a copy of branchPtrWithPatch?

I guess I'll r=me to get the build going -- but testing is for great good.
Comment 4 WebKit Commit Bot 2014-02-26 19:35:59 PST 
Comment on attachment 225335 [details]
Patch

Clearing flags on attachment: 225335

Committed r164774: <http://trac.webkit.org/changeset/164774>
Comment 5 WebKit Commit Bot 2014-02-26 19:36:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Mark Hahnenberg 2014-02-26 22:35:47 PST 
Reopening to attach new patch.
Comment 7 Mark Hahnenberg 2014-02-26 22:35:49 PST 
Created attachment 225345 [details]
Patch
Comment 8 Mark Hahnenberg 2014-02-26 22:36:20 PST 
(In reply to comment #7)
> Created an attachment (id=225345) [details]
> Patch

Another fix for ARM traditional build.
Comment 9 Geoffrey Garen 2014-02-27 00:09:10 PST 
Comment on attachment 225345 [details]
Patch

r=me
Comment 10 WebKit Commit Bot 2014-02-27 00:40:27 PST 
Comment on attachment 225345 [details]
Patch

Clearing flags on attachment: 225345

Committed r164781: <http://trac.webkit.org/changeset/164781>
Comment 11 WebKit Commit Bot 2014-02-27 00:40:29 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Csaba Osztrogonác 2014-02-27 01:44:37 PST 
Reopen, because the ARM traditional build is still broken.

/home/webkitbuildbot/slaves/efl-ARMv7-traditional-official-build/buildslave/efl-linux-armv7-traditional-release/build/Source/JavaScriptCore/assembler/MacroAssemblerARM.h: In member function 'JSC::AbstractMacroAssembler<JSC::ARMAssembler>::DataLabel32 JSC::MacroAssemblerARM::moveWithPatch(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::TrustedImm32, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID)':
/home/webkitbuildbot/slaves/efl-ARMv7-traditional-official-build/buildslave/efl-linux-armv7-traditional-release/build/Source/JavaScriptCore/assembler/MacroAssemblerARM.h:1034:92: error: invalid cast from type 'int32_t {aka int}' to type 'JSC::ARMWord {aka unsigned int}'
Comment 13 Gabor Rapcsanyi 2014-02-27 04:19:53 PST 
Created attachment 225354 [details]
proposed fix

Change reinterpret_cast to static_cast in MacroAssemblerARM::moveWithPatch() and add some missing function.
Comment 14 Zoltan Herczeg 2014-02-27 05:23:34 PST 
Comment on attachment 225354 [details]
proposed fix

r=me
Comment 15 WebKit Commit Bot 2014-02-27 05:56:15 PST 
Comment on attachment 225354 [details]
proposed fix

Clearing flags on attachment: 225354

Committed r164799: <http://trac.webkit.org/changeset/164799>
Comment 16 WebKit Commit Bot 2014-02-27 05:56:17 PST 
All reviewed patches have been landed.  Closing bug.