Bug 129399 – Create symlink to /usr/local/bin/jsc during installation

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

When iOS changes were upstreamed to JavaScriptCore, we lost the creation of a symlink from /usr/local/bin/jsc to /S/L/F/JavaScriptCore.framework/Resources/jsc.

This bug is to track adding that back.

[David Kilzer (:ddkilzer)]

<rdar://problem/16168734>

[David Kilzer (:ddkilzer)]

Created attachment 225306 [details]
Patch v1

Comment on attachment 225306 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=225306&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:5925
> +			shellScript = "if [[ \"${SKIP_INSTALL}\" == \"NO\" ]]; then\n    mkdir -p \"${DSTROOT}/usr/local/bin\"\n    cd \"${DSTROOT}/usr/local/bin\"\n    ln -s \"../../..${INSTALL_PATH}/jsc\" jsc\n    exit\nfi\n";

Unless I’m missing something, when building for the iOS Simulator, this will create the usr directory alongside the Applications directory (which contains Xcode.app/Developer/…) in DSTROOT, which is not desirable in production builds.

s/Developer/Contents\/Developer/

[David Kilzer (:ddkilzer)]

Created attachment 225394 [details]
Patch v2

Fixed install paths for iOS Simulator.

[WebKit Commit Bot]

Comment on attachment 225394 [details]
Patch v2

Clearing flags on attachment: 225394

Committed r164823: <http://trac.webkit.org/changeset/164823>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

I'm seeing build failures on the bots:

<http://build.webkit.org/builders/Apple%20Mavericks%20LLINT%20CLoop%20%28BuildAndTest%29/builds/2260/steps/compile-webkit/logs/stdio>

> The following build commands failed:
>     PhaseScriptExecution Create\ /usr/local/bin/jsc\ symlink

I'm guessing this is because if  there is no iOS SDK then:
DebugRelease.xcconfig line 23: Unable to find included file "../../../../Internal/Configurations/UseInternalSDK.xcconfig"
iOS.xcconfig line 1: Unable to find included file "<DEVELOPER_DIR>/AppleInternal/XcodeConfig/AspenFamily.xcconfig"

And $(INSTALL_PATH_PREFIX) may be undefined? Just a wild guess at this time.

[Joseph Pecoraro]

Or rather, INSTALL_PATH_ACTUAL would be the important thing here.

[David Kilzer (:ddkilzer)]

(In reply to comment #9)
> Or rather, INSTALL_PATH_ACTUAL would be the important thing here.

Actually, the build failed because the buildbot was trying to create a symlink where a symlink already existed (in a non-clean build).

Fixed in r164828:  <http://trac.webkit.org/changeset/r164828>

[Csaba Osztrogonác]

After this change build-jsc unconditionally tries to create 
a symlink to /tmp/JavaScriptCore.dst/usr/local/bin:
jsc -> ../../../System/Library/Frameworks/JavaScriptCore.framework/Versions/A/Resources/jsc

But if there are more user work on a Mac, the second user won't be 
able to remove and recreate this symlink and build-jsc will fail.

Could you possibly give us some hint how can we solve this problem?

[Csaba Osztrogonác]

(In reply to comment #11)
> After this change build-jsc unconditionally tries to create 
> a symlink to /tmp/JavaScriptCore.dst/usr/local/bin:
> jsc -> ../../../System/Library/Frameworks/JavaScriptCore.framework/Versions/A/Resources/jsc
> 
> But if there are more user work on a Mac, the second user won't be 
> able to remove and recreate this symlink and build-jsc will fail.
> 
> Could you possibly give us some hint how can we solve this problem?

Unfortunately I didn't get answer for this serious regression in 2 weeks. :(
I filed a new bug report to fix - https://bugs.webkit.org/show_bug.cgi?id=132053