Bug 129375

Summary:

[CustomGetter] attributes must be in the prototype chain

Product:

WebKit

Reporter:

Thiago de Barros Lacerda <thiago.lacerda>

Component:

JavaScriptCore

Assignee:

Thiago de Barros Lacerda <thiago.lacerda>

Status:

NEW ---

Severity:

Normal

CC:

buildbot, cdumez, cgarcia, commit-queue, oliver, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none

Description Thiago de Barros Lacerda 2014-02-26 10:18:51 PST

https://webkit.org/b/127969 moved all attributes that have automatic generated getters to the prototype chain.
[CustomGetter] attributes, which getters are not trivially generated, must be moved to the prototype chain as well.

Comment 1 Thiago de Barros Lacerda 2014-02-26 12:38:48 PST

Created attachment 225282 [details]
Patch

Comment 2 Build Bot 2014-02-26 13:31:13 PST

Comment on attachment 225282 [details]
Patch

Attachment 225282 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5446586574307328

New failing tests:
svg/masking/mask-negative-scale.svg
http/tests/security/xss-DENIED-assign-location-href-javascript.html

Comment 3 Build Bot 2014-02-26 13:31:15 PST

Created attachment 225290 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 4 Build Bot 2014-02-26 14:23:08 PST

Comment on attachment 225282 [details]
Patch

Attachment 225282 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5851453277077504

New failing tests:
svg/masking/mask-negative-scale.svg
http/tests/security/xss-DENIED-assign-location-href-javascript.html
http/tests/security/cross-frame-access-enumeration.html

Comment 5 Build Bot 2014-02-26 14:23:10 PST

Created attachment 225299 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 6 Build Bot 2014-02-26 15:17:08 PST

Comment on attachment 225282 [details]
Patch

Attachment 225282 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5369119322931200

New failing tests:
http/tests/security/xss-DENIED-assign-location-href-javascript.html
http/tests/security/cross-frame-access-enumeration.html

Comment 7 Build Bot 2014-02-26 15:17:12 PST

Created attachment 225305 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 8 Sam Weinig 2014-10-30 06:14:45 PDT

Comment on attachment 225282 [details]
Patch

This needs a test case.