Bug 129304

Summary:

Inspector server should be enabled only when the web sockets is enabled too.

Product:

WebKit

Reporter:

Gergő Balogh <gbalogh.u-szeged>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, ossy, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	ossy: review+, ossy: commit-queue-
changelog typo fix	none

Description Gergő Balogh 2014-02-25 06:13:57 PST

The inspector won't work when the web sockets is disabled.

Comment 1 Radar WebKit Bug Importer 2014-02-25 06:14:17 PST

<rdar://problem/16159582>

Comment 2 Gergő Balogh 2014-02-25 06:18:43 PST

Created attachment 225144 [details]
patch

Comment 3 Csaba Osztrogonác 2014-02-25 06:48:39 PST

Comment on attachment 225144 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225144&action=review

The fix LGTM, but please fix the changelog.

> Source/WebKit2/ChangeLog:3
> +        Inspector should be enabled only when the web sockets is enabled too.

You meant "Inspector _server_ should be enabled only when the web sockets is enabled too."

Comment 4 Gergő Balogh 2014-02-25 23:42:04 PST

Created attachment 225229 [details]
changelog typo fix

Comment 5 WebKit Commit Bot 2014-02-26 05:34:57 PST

Comment on attachment 225229 [details]
changelog typo fix

Clearing flags on attachment: 225229

Committed r164714: <http://trac.webkit.org/changeset/164714>

Comment 6 WebKit Commit Bot 2014-02-26 05:34:59 PST

All reviewed patches have been landed.  Closing bug.