RESOLVED FIXED 129304
Inspector server should be enabled only when the web sockets is enabled too. 
https://bugs.webkit.org/show_bug.cgi?id=129304
Summary Inspector server should be enabled only when the web sockets is enabled too.
Gergő Balogh
Reported 2014-02-25 06:13:57 PST
The inspector won't work when the web sockets is disabled.
Attachments
patch (1.09 KB, patch)
2014-02-25 06:18 PST, Gergő Balogh 		ossy: review+
ossy: commit-queue-
DetailsFormatted DiffDiff
changelog typo fix (1.09 KB, patch)
2014-02-25 23:42 PST, Gergő Balogh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-25 06:14:17 PST
<rdar://problem/16159582>
Gergő Balogh
Comment 2 2014-02-25 06:18:43 PST
Created attachment 225144 [details] patch
Csaba Osztrogonác
Comment 3 2014-02-25 06:48:39 PST
Comment on attachment 225144 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=225144&action=review The fix LGTM, but please fix the changelog. > Source/WebKit2/ChangeLog:3 > + Inspector should be enabled only when the web sockets is enabled too. You meant "Inspector _server_ should be enabled only when the web sockets is enabled too."
Gergő Balogh
Comment 4 2014-02-25 23:42:04 PST
Created attachment 225229 [details] changelog typo fix
WebKit Commit Bot
Comment 5 2014-02-26 05:34:57 PST
Comment on attachment 225229 [details] changelog typo fix Clearing flags on attachment: 225229 Committed r164714: <http://trac.webkit.org/changeset/164714>
WebKit Commit Bot
Comment 6 2014-02-26 05:34:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.