Bug 129276

Summary: Use RetainPtrs for two WKContentView data members
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, enrica, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch benjamin: review+

Description Simon Fraser (smfr) 2014-02-24 16:33:29 PST 
Use RetainPtrs for two WKContentView data members
Comment 1 Simon Fraser (smfr) 2014-02-24 16:35:45 PST 
Created attachment 225103 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-02-24 16:36:09 PST 
Depends on earlier patch.
Comment 3 Simon Fraser (smfr) 2014-02-24 18:40:23 PST 
Created attachment 225109 [details]
Patch
Comment 4 Benjamin Poulain 2014-02-24 18:42:41 PST 
Comment on attachment 225109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225109&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:113
>  @property (nonatomic, readonly) BOOL isEditable;
> +@property (readonly, nonatomic) const WebKit::InteractionInformationAtPosition& positionInformation;
> +@property (readonly, nonatomic) const WebKit::WKAutoCorrectionData& autocorrectionData;

Switch nonatomic and readonly here for consistency?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:188
> +    [_formAccessoryView release];

_formAccessoryView = nil;
Comment 5 Simon Fraser (smfr) 2014-02-24 18:54:12 PST 
https://trac.webkit.org/r164622