| Summary: | JSC regressions after r164494 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | peavo | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, mark.lam, mhahnenberg, msaboff | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac (Intel) | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
peavo
2014-02-24 13:41:06 PST
Created attachment 225095 [details]
Patch
Comment on attachment 225095 [details]
Patch
r=me
Created attachment 225096 [details]
Patch
Comment on attachment 225096 [details] Patch I don't know the x87 instructions, but In the original patch <http://trac.webkit.org/changeset/164494>, you modified all 3 cases in that if else statement blob. Do the other 2 cases need to be conditional on isIntelSyntax as well? Please comment. Thanks. (In reply to comment #4) > (From update of attachment 225096 [details]) > I don't know the x87 instructions, but In the original patch <http://trac.webkit.org/changeset/164494>, you modified all 3 cases in that if else statement blob. Do the other 2 cases need to be conditional on isIntelSyntax as well? Please comment. Thanks. No, I believe I only added the orderOperands function there, which will do nothing for !isIntelSyntax. Comment on attachment 225096 [details]
Patch
r=me
Comment on attachment 225096 [details] Patch Clearing flags on attachment: 225096 Committed r164612: <http://trac.webkit.org/changeset/164612> All reviewed patches have been landed. Closing bug. (In reply to comment #6) > (From update of attachment 225096 [details]) > r=me Thanks, sorry for the fuzz ... *** Bug 129281 has been marked as a duplicate of this bug. *** |