Bug 129272

Summary: JSC regressions after r164494
Product: WebKit Reporter: peavo
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, mhahnenberg, msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

peavo
Reported 2014-02-24 13:41:06 PST
The patch in bug 129155 caused many JSC test failures for 32-bit Mac and GTK.
Attachments
Patch (1.61 KB, patch)
2014-02-24 14:05 PST, peavo 		no flags
DetailsFormatted DiffDiff
Patch (1.60 KB, patch)
2014-02-24 14:13 PST, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2014-02-24 14:05:42 PST
Created attachment 225095 [details] Patch
Geoffrey Garen
Comment 2 2014-02-24 14:11:24 PST
Comment on attachment 225095 [details] Patch r=me
peavo
Comment 3 2014-02-24 14:13:40 PST
Created attachment 225096 [details] Patch
Mark Lam
Comment 4 2014-02-24 14:22:02 PST
Comment on attachment 225096 [details] Patch I don't know the x87 instructions, but In the original patch <http://trac.webkit.org/changeset/164494>, you modified all 3 cases in that if else statement blob. Do the other 2 cases need to be conditional on isIntelSyntax as well? Please comment. Thanks.
peavo
Comment 5 2014-02-24 14:25:39 PST
(In reply to comment #4) > (From update of attachment 225096 [details]) > I don't know the x87 instructions, but In the original patch <http://trac.webkit.org/changeset/164494>, you modified all 3 cases in that if else statement blob. Do the other 2 cases need to be conditional on isIntelSyntax as well? Please comment. Thanks. No, I believe I only added the orderOperands function there, which will do nothing for !isIntelSyntax.
Mark Lam
Comment 6 2014-02-24 14:31:06 PST
Comment on attachment 225096 [details] Patch r=me
WebKit Commit Bot
Comment 7 2014-02-24 14:53:17 PST
Comment on attachment 225096 [details] Patch Clearing flags on attachment: 225096 Committed r164612: <http://trac.webkit.org/changeset/164612>
WebKit Commit Bot
Comment 8 2014-02-24 14:53:19 PST
All reviewed patches have been landed. Closing bug.
peavo
Comment 9 2014-02-24 14:55:26 PST
(In reply to comment #6) > (From update of attachment 225096 [details]) > r=me Thanks, sorry for the fuzz ...
Mark Hahnenberg
Comment 10 2014-02-24 18:13:37 PST
*** Bug 129281 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.