Summary: | Web Inspector: Toolbar is all white on non-Mac platforms | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Timothy Hatcher
2014-02-24 11:12:53 PST
Created attachment 225076 [details]
Patch
Comment on attachment 225076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:203 > + } else if (navigator.platform.contains("Win")) > + document.body.classList.add("windows-platform"); > + else if (navigator.platform.contains("Linux")) > + document.body.classList.add("linux-platform"); > + else > + document.body.classList.add("other-platform"); Should we use InspectorFrontendHost.platform instead? It would simplify things a bit. Comment on attachment 225076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review > Source/WebInspectorUI/UserInterface/Views/Toolbar.css:58 > + background-image: -webkit-linear-gradient(top, rgb(233, 233, 233), rgb(229, 229, 229)); You could have used the W3C syntax as follows, with the default value for the orientation: linear-gradient(rgb(229, 229, 229), rgb(233, 233, 233)); Comment on attachment 225076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225076&action=review >> Source/WebInspectorUI/UserInterface/Views/Toolbar.css:58 >> + background-image: -webkit-linear-gradient(top, rgb(233, 233, 233), rgb(229, 229, 229)); > > You could have used the W3C syntax as follows, with the default value for the orientation: linear-gradient(rgb(229, 229, 229), rgb(233, 233, 233)); I fixed all our gradients to use the in prefixed version in a follow up. |