Bug 129259 – Subpixel rendering: Ensure consistent border painting width.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

class BorderEdge should return width in device pixels so that when the border rect for painting is calculated, the position does not impact border width, in other words, border widths are consistent across edges.

[zalan]

(In reply to comment #0)
> class BorderEdge should return width in device pixels so that when the border rect for painting is calculated, the position does not impact border width, in other words, border widths are consistent across edges.

position + fractional border width.

[zalan]

Created attachment 225089 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 225089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225089&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1452
> +    float widthForPainting() const { return isPresent ?  flooredToDevicePixelWidth : 0.f; }

Is the .f required?

[zalan]

(In reply to comment #3)
> (From update of attachment 225089 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225089&action=review
> 
> > Source/WebCore/rendering/RenderBoxModelObject.cpp:1452
> > +    float widthForPainting() const { return isPresent ?  flooredToDevicePixelWidth : 0.f; }
> 
> Is the .f required?

Probably just a leftover from my previous attempts. Will remove it before committing. Thanks!

[zalan]

Created attachment 225215 [details]
Patch

[zalan]

Comment on attachment 225215 [details]
Patch

EWS testing

[WebKit Commit Bot]

Comment on attachment 225215 [details]
Patch

Clearing flags on attachment: 225215

Committed r164698: <http://trac.webkit.org/changeset/164698>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.