REGRESSION(r164438): [GTK] Tests /webkit2/WebKitWebView/tls-errors-policy and /webkit2/WebKitWebContext/uri-scheme fail

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

/webkit2/WebKitWebContext/uri-scheme: **
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:225:void testWebContextURIScheme(URISchemeTest*, gconstpointer): assertion failed (test->m_error.get() == (test, 10)): Error message. (test, 399)

/webkit2/WebKitWebView/tls-errors-policy: **
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:45:virtual void SSLTest::provisionalLoadFailed(const gchar*, GError*): assertion failed (error == (soup_http_error_quark, 6)): Unacceptable TLS certificate (soup_http_error_quark, 399)

This is because we are assuming all error codes come from WebCore. I think in the case of errors we should not use the conversion functions or at least we should not assert in default: and return the passed in error code instead of falling back to network error.

[Enrique Ocaña]

Created attachment 225056 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Enrique Ocaña]

The root cause of this bug is related to the root cause of #129256, but this time in WK2.

[WebKit Commit Bot]

Comment on attachment 225056 [details]
Patch

Clearing flags on attachment: 225056

Committed r164597: <http://trac.webkit.org/changeset/164597>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.