Bug 129226

Summary: Subpixel rendering: Add subpixel support to border type of double, groove, ridge, inset and outset.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bhell, commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2014-02-22 20:53:05 PST
Dotted and dashed need GraphicsContext::drawLine() cleanup. There's some odd legacy code there with full of (false) assumptions.
Comment 1 zalan 2014-02-25 14:57:30 PST
Created attachment 225186 [details]
Patch
Comment 2 zalan 2014-02-26 08:19:39 PST
Created attachment 225256 [details]
Patch
Comment 3 zalan 2014-02-26 08:20:02 PST
Comment on attachment 225256 [details]
Patch

EWSing.
Comment 4 Simon Fraser (smfr) 2014-02-26 14:52:31 PST
Comment on attachment 225256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225256&action=review

> Source/WebCore/rendering/RenderObject.cpp:738
> +    // FIXME: flooring is a temporary solution until the device pixel snapping is added here for all border types (including recursiveness).

"including recursiveness" is weird.
Comment 5 zalan 2014-02-28 13:26:46 PST
Created attachment 225485 [details]
Patch
Comment 6 WebKit Commit Bot 2014-02-28 15:00:28 PST
Comment on attachment 225485 [details]
Patch

Clearing flags on attachment: 225485

Committed r164888: <http://trac.webkit.org/changeset/164888>
Comment 7 WebKit Commit Bot 2014-02-28 15:00:32 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 zalan 2014-03-05 09:38:22 PST
*** Bug 129329 has been marked as a duplicate of this bug. ***
Comment 9 Joseph Pecoraro 2015-11-12 13:08:39 PST
*** Bug 113642 has been marked as a duplicate of this bug. ***