Summary: | REGRESSION(r164412): Pixel cracks when zooming in to any web content. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2014-02-21 21:22:51 PST
Created attachment 224946 [details]
Patch
Comment on attachment 224946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2243 > + LayoutRect dirtyRect(enclosingIntRect(clip)); > IntRect pixelSnappedRectForIntegralPositionedItems = pixelSnappedIntRect(dirtyRect); Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect(). Should it be an IntRect? (In reply to comment #3) > (From update of attachment 224946 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:2243 > > + LayoutRect dirtyRect(enclosingIntRect(clip)); > > IntRect pixelSnappedRectForIntegralPositionedItems = pixelSnappedIntRect(dirtyRect); > > Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect(). Should it be an IntRect? Yes, it looks odd, but I left it there so that when I clean up the paint rect clipping all I need to change back is the dirtyRect and the pixelSnappedRectForIntegralPositionedItems can stay as it is. (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 224946 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=224946&action=review > > > > > Source/WebCore/rendering/RenderLayerBacking.cpp:2243 > > > + LayoutRect dirtyRect(enclosingIntRect(clip)); > > > IntRect pixelSnappedRectForIntegralPositionedItems = pixelSnappedIntRect(dirtyRect); > > > > Odd that you call pixelSnappedIntRect() on the result of enclosingIntRect(). Should it be an IntRect? > Yes, it looks odd, but I left it there so that when I clean up the paint rect clipping all I need to change back is the dirtyRect and the pixelSnappedRectForIntegralPositionedItems can stay as it is. I guess I should remove it to not to cause any confusion. (as it might take a few days to get to the clipping cleanup) Just add a comment if you plan to come back to it. Created attachment 224948 [details]
Patch
Comment on attachment 224948 [details]
Patch
EWSing.
(In reply to comment #6) > Just add a comment if you plan to come back to it. I prefer what you suggested first. It's more explicit that way. Thanks for the review. Comment on attachment 224948 [details] Patch Clearing flags on attachment: 224948 Committed r164532: <http://trac.webkit.org/changeset/164532> All reviewed patches have been landed. Closing bug. |