Bug 129182 – [WebRTC] Validating RTCConfiguration according to the spec

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Thiago de Barros Lacerda]

Spec states that:
   - iceServers should not be an empty list
   - the entry in the configuration dictionary is "urls", instead of "url"
   - urls can be either a list or a string
Fixing all that in RTCConfiguration validation when creating a RTCPeerConnection

[Thiago de Barros Lacerda]

Created attachment 224926 [details]
Patch

[Eric Carlson]

Comment on attachment 224926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224926&action=review

I might have missed it, but I don't see any new tests that pass a list of urls.

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:83
> +    // Spec says that "urls" can be either a string or a sequence, so we must check for both.
> +    Vector<String> urlsList;
> +    String urlString;

Nit: this can move down where the variables are used.

[Thiago de Barros Lacerda]

Created attachment 225080 [details]
Requested changes

[WebKit Commit Bot]

Comment on attachment 225080 [details]
Requested changes

Clearing flags on attachment: 225080

Committed r164602: <http://trac.webkit.org/changeset/164602>