Bug 129160

Summary: DFG write barriers should do more speculations
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED INVALID    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, ossy, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mhahnenberg: review+

Filip Pizlo
Reported 2014-02-21 12:13:49 PST
Patch forthcoming.
Attachments
the patch (10.98 KB, patch)
2014-02-21 12:15 PST, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-21 12:15:36 PST
Created attachment 224888 [details] the patch
Mark Hahnenberg
Comment 2 2014-02-21 12:23:56 PST
Comment on attachment 224888 [details] the patch r=me
Filip Pizlo
Comment 3 2014-02-21 12:32:18 PST
Landed in http://trac.webkit.org/changeset/164493
Ryosuke Niwa
Comment 4 2014-02-24 13:23:50 PST
Looks like this patch caused/revealed a crash on DYEBench.
Filip Pizlo
Comment 5 2014-02-25 09:37:56 PST
It's causing crashes.
Filip Pizlo
Comment 6 2014-02-25 09:43:24 PST
Landed in http://trac.webkit.org/changeset/164651
Csaba Osztrogonác
Comment 7 2014-02-26 06:12:16 PST
(In reply to comment #3) > Landed in http://trac.webkit.org/changeset/164493 just to note: It caused this bug - https://bugs.webkit.org/show_bug.cgi?id=129247 (which appeared after rolling out)
Filip Pizlo
Comment 8 2015-05-14 12:29:03 PDT
We landed something like this a whiel ago.
Note You need to log in before you can comment on or make changes to this bug.