Bug 129160 - DFG write barriers should do more speculations
Summary: DFG write barriers should do more speculations
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mark Hahnenberg
Depends on:
Reported: 2014-02-21 12:13 PST by Filip Pizlo
Modified: 2015-05-14 12:29 PDT (History)
11 users (show)

See Also:

the patch (10.98 KB, patch)
2014-02-21 12:15 PST, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-21 12:13:49 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2014-02-21 12:15:36 PST
Created attachment 224888 [details]
the patch
Comment 2 Mark Hahnenberg 2014-02-21 12:23:56 PST
Comment on attachment 224888 [details]
the patch

Comment 3 Filip Pizlo 2014-02-21 12:32:18 PST
Landed in http://trac.webkit.org/changeset/164493
Comment 4 Ryosuke Niwa 2014-02-24 13:23:50 PST
Looks like this patch caused/revealed a crash on DYEBench.
Comment 5 Filip Pizlo 2014-02-25 09:37:56 PST
It's causing crashes.
Comment 6 Filip Pizlo 2014-02-25 09:43:24 PST
Landed in http://trac.webkit.org/changeset/164651
Comment 7 Csaba Osztrogonác 2014-02-26 06:12:16 PST
(In reply to comment #3)
> Landed in http://trac.webkit.org/changeset/164493

just to note: It caused this bug - https://bugs.webkit.org/show_bug.cgi?id=129247
(which appeared after rolling out)
Comment 8 Filip Pizlo 2015-05-14 12:29:03 PDT
We landed something like this a whiel ago.