Bug 129152

Summary:

[CMake] Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt

Product:

WebKit

Reporter:

Tibor Mészáros <mtiborinf>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, commit-queue, gyuyoung.kim, ossy, rakuco, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
patch for landing	none

Tibor Mészáros

Reported 2014-02-21 08:12:46 PST

Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt

Attachments
Patch (2.74 KB, patch) 2014-02-21 08:19 PST, Tibor Mészáros	no flags	Details Formatted Diff Diff
patch for landing (3.07 KB, patch) 2014-02-24 06:57 PST, Tibor Mészáros	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tibor Mészáros

Comment 1 2014-02-21 08:19:31 PST

Created attachment 224867 [details] Patch The explicitly demarcated SVG IDL files (from WebCore_SVG_IDL_FILES) are added to WebCore_IDL_FILES.

Raphael Kubo da Costa (:rakuco)

Comment 2 2014-02-21 09:00:26 PST

Comment on attachment 224867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224867&action=review > Source/WebCore/CMakeLists.txt:578 > +svg/SVGAElement.idl Nit: wrong indentation?

Gyuyoung Kim

Comment 3 2014-02-22 02:04:42 PST

Comment on attachment 224867 [details] Patch Please land after fixing the nit.

Tibor Mészáros

Comment 4 2014-02-24 06:57:31 PST

Created attachment 225062 [details] patch for landing

WebKit Commit Bot

Comment 5 2014-02-24 07:41:51 PST

Comment on attachment 225062 [details] patch for landing Clearing flags on attachment: 225062 Committed r164586: <http://trac.webkit.org/changeset/164586>

WebKit Commit Bot

Comment 6 2014-02-24 07:41:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.