Bug 129152 - [CMake] Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt
Summary: [CMake] Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-21 08:12 PST by Tibor Mészáros
Modified: 2014-02-24 07:41 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2014-02-21 08:19 PST, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
patch for landing (3.07 KB, patch)
2014-02-24 06:57 PST, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tibor Mészáros 2014-02-21 08:12:46 PST 
Get rid of "FIXME: The Blackberry port ..."  from WebCore/CmakeLists.txt
Comment 1 Tibor Mészáros 2014-02-21 08:19:31 PST 
Created attachment 224867 [details]
Patch

The explicitly demarcated SVG IDL files (from WebCore_SVG_IDL_FILES) are added to WebCore_IDL_FILES.
Comment 2 Raphael Kubo da Costa (:rakuco) 2014-02-21 09:00:26 PST 
Comment on attachment 224867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224867&action=review

> Source/WebCore/CMakeLists.txt:578
> +svg/SVGAElement.idl

Nit: wrong indentation?
Comment 3 Gyuyoung Kim 2014-02-22 02:04:42 PST 
Comment on attachment 224867 [details]
Patch

Please land after fixing the nit.
Comment 4 Tibor Mészáros 2014-02-24 06:57:31 PST 
Created attachment 225062 [details]
patch for landing
Comment 5 WebKit Commit Bot 2014-02-24 07:41:51 PST 
Comment on attachment 225062 [details]
patch for landing

Clearing flags on attachment: 225062

Committed r164586: <http://trac.webkit.org/changeset/164586>
Comment 6 WebKit Commit Bot 2014-02-24 07:41:54 PST 
All reviewed patches have been landed.  Closing bug.