Bug 129075

Summary: RenderBox::updateShapeOutsideInfoAfterStyleChange shows up on profiles
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: betravis, commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2014-02-19 16:46:20 PST
updateShapeOutsideInfoAfterStyleChange should never show up on profiles if shapes are not being used. We need to make sure it doesn't impact perf. I was seeing it as 0.3% of time.
Attachments
Patch (1.47 KB, patch)
2014-02-19 16:58 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-02-19 16:58:59 PST
Created attachment 224693 [details] Patch
Bear Travis
Comment 2 2014-02-20 10:50:00 PST
Seems fine to me. It looks like Shape Inside may suffer from a similar concern with RenderBlock::updateShapeInsideInfoAfterStyleChange. I can fix that up after this lands.
WebKit Commit Bot
Comment 3 2014-02-20 21:56:55 PST
Comment on attachment 224693 [details] Patch Clearing flags on attachment: 224693 Committed r164471: <http://trac.webkit.org/changeset/164471>
WebKit Commit Bot
Comment 4 2014-02-20 21:56:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.