Bug 129022

Summary: Add FeatureDefines for image controls
Product: WebKit Reporter: Brady Eidson <beidson>
Component: ImagesAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 129028    
Attachments:
Description Flags
Patch v1 none

Description Brady Eidson 2014-02-18 20:37:43 PST 
Add FeatureDefines for image controls

Image controls will be platform-specific UI on top of images.  To help with development that requires constant rolling-in and rolling-out of patches, it'll be a big help to land the feature defines separately.
Comment 1 Brady Eidson 2014-02-18 20:45:02 PST 
Created attachment 224582 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-02-19 09:30:34 PST 
Comment on attachment 224582 [details]
Patch v1

Clearing flags on attachment: 224582

Committed r164366: <http://trac.webkit.org/changeset/164366>
Comment 3 WebKit Commit Bot 2014-02-19 09:30:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Joseph Pecoraro 2014-02-19 11:12:18 PST 
Comment on attachment 224582 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=224582&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:96
> +ENABLE_IMAGE_CONTROLS_macosx_1080 = ;
> +ENABLE_IMAGE_CONTROLS_macosx_1090 = ;
> +ENABLE_IMAGE_CONTROLS_macosx_101000 = ENABLE_IMAGE_CONTROLS;

I wonder why we include 1080 and 1090 if the feature is not enabled there. We could just leave them off right?