Bug 129016

Summary:

Clean up WKContentView initialization

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	benjamin: review+, benjamin: commit-queue-

Description Simon Fraser (smfr) 2014-02-18 18:32:37 PST

Clean up WKContentView initialization

Comment 1 Simon Fraser (smfr) 2014-02-18 18:34:15 PST

Created attachment 224575 [details]
Patch

Comment 2 Benjamin Poulain 2014-02-18 18:37:02 PST

Comment on attachment 224575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224575&action=review

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:246
> -    _contentView = adoptNS([[WKContentView alloc] initWithFrame:bounds contextRef:contextRef pageGroupRef:pageGroupRef relatedToPage:relatedPage]);
> +    WebKit::WebPageConfiguration webPageConfiguration;
> +    webPageConfiguration.pageGroup = toImpl(pageGroupRef);
> +    webPageConfiguration.relatedPage = toImpl(relatedPage);
> +
> +    _contentView = adoptNS([[WKContentView alloc] initWithFrame:bounds context:*toImpl(contextRef) configuration:std::move(webPageConfiguration)]);

You need to update WKWebView accordingly :(

Comment 3 Simon Fraser (smfr) 2014-02-18 20:06:35 PST

WKWebView already uses the correct initializer.

Comment 4 Simon Fraser (smfr) 2014-02-18 20:07:59 PST

http://trac.webkit.org/changeset/164349