Bug 129000 – [WebRTC] Updating RTCConfiguration to match WebRTC editor's draft of 01/27/2014

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Thiago de Barros Lacerda]

Adding RTCIceTransports and RTCIdentityOption to RTCConfiguration object

[Thiago de Barros Lacerda]

Created attachment 224553 [details]
Patch

[Eric Carlson]

Comment on attachment 224553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224553&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:77
> +    String iceTransports;
> +    String requestIdentity;

Nit: these can be declared just before they are used.

> Source/WebCore/platform/mediastream/RTCConfiguration.h:77
> +    const String& iceTransports() { return m_iceTransports; }

Nit: this method can be made const.

> Source/WebCore/platform/mediastream/RTCConfiguration.h:83
> +    const String& requestIdentity() { return m_requestIdentity; }

Ditto.

[Thiago de Barros Lacerda]

Created attachment 224646 [details]
Requested changes

[WebKit Commit Bot]

Comment on attachment 224646 [details]
Requested changes

Clearing flags on attachment: 224646

Committed r164372: <http://trac.webkit.org/changeset/164372>