Summary: | [WebRTC] Updating RTCConfiguration to match WebRTC editor's draft of 01/27/2014 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||
Component: | WebCore Misc. | Assignee: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, hta, jer.noble, philipj, pnormand, sergio, tommyw | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 124288 | ||||||||
Attachments: |
|
Description
Thiago de Barros Lacerda
2014-02-18 14:25:30 PST
Created attachment 224553 [details]
Patch
Comment on attachment 224553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224553&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:77 > + String iceTransports; > + String requestIdentity; Nit: these can be declared just before they are used. > Source/WebCore/platform/mediastream/RTCConfiguration.h:77 > + const String& iceTransports() { return m_iceTransports; } Nit: this method can be made const. > Source/WebCore/platform/mediastream/RTCConfiguration.h:83 > + const String& requestIdentity() { return m_requestIdentity; } Ditto. Created attachment 224646 [details]
Requested changes
Comment on attachment 224646 [details] Requested changes Clearing flags on attachment: 224646 Committed r164372: <http://trac.webkit.org/changeset/164372> |