Bug 128993

Summary: Merge notifyComponentsOnChangedSelection into respondToSelectionChange
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, enrica, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 127832    
Attachments:
Description Flags
Patch kling: review+

Ryosuke Niwa
Reported 2014-02-18 13:47:10 PST
notifyComponentsOnChangedSelection was added in a very old WebKit merge in the downstream repository when we added alternative text controller in WebKit to respondToSelectionChange. The person who merged WebKit change probably didn't realize this but things in respondToSelectionChange should really be moved into notifyComponentsOnChangedSelection and vice versa so simply merge them together.
Attachments
Patch (4.70 KB, patch)
2014-02-18 13:53 PST, Ryosuke Niwa 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-02-18 13:53:31 PST
Created attachment 224543 [details] Patch
Andreas Kling
Comment 2 2014-02-18 14:23:20 PST
Comment on attachment 224543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224543&action=review Seems reasonable. r=me > Source/WebCore/editing/Editor.cpp:3300 > + // FIXME: Merge this to open source https://bugs.webkit.org/show_bug.cgi?id=38830 Is this comment actually relevant? We are *in* open source :)
Ryosuke Niwa
Comment 3 2014-02-18 14:33:24 PST
Committed r164320: <http://trac.webkit.org/changeset/164320>
Note You need to log in before you can comment on or make changes to this bug.