Bug 128992

Summary: Enable the Selector Compiler on Windows
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ahmad.saleem792, bfulgham, cmarcelo, commit-queue, don.olmstead, fujii.hironori, ian.grunert, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127827    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2014-02-18 13:44:38 PST
Enable the Selector Compiler on Windows
Attachments
Patch (3.47 KB, patch)
2014-02-18 13:45 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-02-18 13:45:53 PST
Created attachment 224539 [details] Patch
Benjamin Poulain
Comment 2 2014-02-18 13:48:28 PST
This is 100% untested :) You need to enable the JS JIT, but not DFG nor FTL. Can one of you give this a shot?
Brent Fulgham
Comment 3 2014-03-25 14:51:19 PDT
The 64-bit Windows JIT is not enabled at the moment. This bug is on hold until that happens. :-(
Benjamin Poulain
Comment 4 2014-03-25 14:56:39 PDT
(In reply to comment #3) > The 64-bit Windows JIT is not enabled at the moment. This bug is on hold until that happens. :-( Oh, not even the baseline JIT :(
Alex Christensen
Comment 5 2014-05-27 10:01:19 PDT
I assume this is correct based on http://msdn.microsoft.com/en-us/library/6t169e9c.aspx I tested the css jit by applying https://bugs.webkit.org/show_bug.cgi?id=130638 and it *seemed* to work but I did not do rigorous enough testing to use enough registers for problems to arise. Is there a good way to test using a lot of registers in the css jit?
Alex Christensen
Comment 6 2014-05-29 18:40:06 PDT
This patch needs to be updated to apply cleanly with the changes since February, but the registers are correct. Without this change, these tests crash: fast/selectors/case-insensitive-value-matching.html fast/selectors/querySelector-rightmost-child-chain-attribute-matching.html fast/selectors/querySelector-long-attribute-match-with-child-backtracking.html fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html fast/selectors/querySelector-long-multiple-attribute-match-with-child-backtracking.html fast/selectors/tree-modifying-case-insensitive-selectors.html fast/selectors/nth-child-with-backtracking.html fast/selectors/tree-modifying-selectors.html fast/selectors/querySelector-multiple-attribute-match-with-child-backtracking.html With this change all fast/selectors tests run without crashing.
Ian Grunert
Comment 7 2023-10-21 16:56:17 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19395
EWS
Comment 8 2023-10-22 16:01:09 PDT
Committed 269638@main (ebfdd1c36b09): <https://commits.webkit.org/269638@main> Reviewed commits have been landed. Closing PR #19395 and removing active labels.
Radar WebKit Bug Importer
Comment 9 2023-10-22 16:02:16 PDT
<rdar://problem/117329024>
Note You need to log in before you can comment on or make changes to this bug.