Bug 128966

Summary: Flex-box selection is not proper
Product: WebKit Reporter: Sudarshan C P <sudarshan.cp>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahmad.saleem792, buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test page
none
Mozilla behavior png
none
Webkit behavior
none
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
none
Patch
none
Patch simon.fraser: review-

Description Sudarshan C P 2014-02-18 04:18:01 PST 
1.Fetch the attached page
2.place the cursor at the middle of any box
3.press ctr+A(Select all)

Current behavior:
Selection is not proper

Expected behavior:
selection should be proper
Comment 1 Sudarshan C P 2014-02-18 04:19:03 PST 
Created attachment 224494 [details]
Test page
Comment 2 Sudarshan C P 2014-02-18 04:19:38 PST 
Created attachment 224495 [details]
Mozilla behavior png
Comment 3 Sudarshan C P 2014-02-18 04:20:31 PST 
Created attachment 224496 [details]
Webkit behavior
Comment 4 Sudarshan C P 2014-02-18 05:29:08 PST 
Created attachment 224499 [details]
Patch
Comment 5 WebKit Commit Bot 2014-02-18 05:30:37 PST 
Attachment 224499 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Sudarshan C P 2014-02-18 05:31:09 PST 
(In reply to comment #4)
> Created an attachment (id=224499) [details]
> Patch

WIP
Comment 7 Sudarshan C P 2014-02-18 05:38:19 PST 
Created attachment 224500 [details]
Patch
Comment 8 Build Bot 2014-02-18 06:45:27 PST 
Comment on attachment 224500 [details]
Patch

Attachment 224500 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6532200124121088

New failing tests:
fast/repaint/selection-gap-absolute-child.html
fast/repaint/selection-gap-transformed-absolute-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-transformed-fixed-child.html
fast/block/line-layout/selection-highlight-overlap.html
Comment 9 Build Bot 2014-02-18 06:45:28 PST 
Created attachment 224505 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2014-02-18 07:04:55 PST 
Comment on attachment 224500 [details]
Patch

Attachment 224500 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4512801796128768

New failing tests:
fast/repaint/selection-gap-transformed-fixed-child.html
fast/repaint/selection-gap-fixed-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-flipped-fixed-child.html
fast/block/line-layout/selection-highlight-overlap.html
fast/repaint/selection-gap-absolute-child.html
fast/repaint/selection-gap-transformed-absolute-child.html
Comment 11 Build Bot 2014-02-18 07:04:58 PST 
Created attachment 224506 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 12 Build Bot 2014-02-18 08:11:48 PST 
Comment on attachment 224500 [details]
Patch

Attachment 224500 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5335931473100800

New failing tests:
fast/repaint/selection-gap-transformed-fixed-child.html
fast/repaint/selection-gap-fixed-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-flipped-fixed-child.html
fast/block/line-layout/selection-highlight-overlap.html
fast/repaint/selection-gap-absolute-child.html
fast/repaint/selection-gap-transformed-absolute-child.html
Comment 13 Build Bot 2014-02-18 08:11:53 PST 
Created attachment 224514 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 14 Sudarshan C P 2014-02-19 03:25:25 PST 
Created attachment 224618 [details]
Patch
Comment 15 Sudarshan C P 2014-02-24 00:51:33 PST 
Fixed in latest binary please close the bug.
Comment 16 Sudarshan C P 2014-02-24 00:52:10 PST 
Fixed in latest binary please close the bug.
Comment 17 zalan 2014-03-02 14:44:34 PST 
Add a test case, please!
Comment 18 Sudarshan C P 2014-03-02 21:01:33 PST 
Thanks for updating the command,i will upload the test case ASAP.
Comment 19 Sudarshan C P 2014-03-04 02:25:26 PST 
Created attachment 225765 [details]
Patch
Comment 20 Sudarshan C P 2014-03-11 20:30:53 PDT 
(In reply to comment #17)
> Add a test case, please!
I have uploaded the test case could you please review
Comment 21 Simon Fraser (smfr) 2014-03-11 20:49:30 PDT 
Comment on attachment 225765 [details]
Patch

There is no code change in this patch.
Comment 22 Sudarshan C P 2014-03-11 21:31:35 PDT 
(In reply to comment #21)
> (From update of attachment 225765 [details])
> There is no code change in this patch.

reported issue is indirectly fixed in latest binary, so reviewer expected to upload the test case, hence added the layout test case to close the issue,Please review the test case.
Comment 23 Ahmad Saleem 2023-02-24 15:04:16 PST 
Marking this as "Duplicate" since the text selection in flexbox and grid was fixed and now in Safari 16.4 Beta 1.

*** This bug has been marked as a duplicate of bug 119878 ***