Bug 128957

Summary: [GStreamer] the GstPlayFlags enum diverged from upstream
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, commit-queue, eric.carlson, glenn, gustavo, jer.noble, menard, mrobinson, philipj, sergio, vjaquez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Philippe Normand 2014-02-17 23:40:09 PST 
The GST_PLAY_FLAG_BUFFERING value is wrong now (how come?), the deinterlace and soft-colorbalance flags are missing.
Comment 1 Xabier Rodríguez Calvar 2014-02-18 01:11:10 PST 
This is going to be fun to support.
Comment 2 Xabier Rodríguez Calvar 2014-02-18 09:34:58 PST 
Created attachment 224521 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2014-02-18 09:36:02 PST 
Comment on attachment 224521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224521&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:170
> +    GFlagsClass* flagsClass = static_cast<GFlagsClass*>(g_type_class_ref(g_type_from_name("GstPlayFlags")));

I was thinking of caching this by making it static. What do you think, Phil?
Comment 4 Philippe Normand 2014-02-18 23:10:22 PST 
Comment on attachment 224521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224521&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:168
> +static unsigned getGstPlaysFlag(const char* nick)

Perhaps this could be moved to GStreamerUtilities

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:170
>> +    GFlagsClass* flagsClass = static_cast<GFlagsClass*>(g_type_class_ref(g_type_from_name("GstPlayFlags")));
> 
> I was thinking of caching this by making it static. What do you think, Phil?

Ok but then no unref below I suppose :)
Comment 5 Xabier Rodríguez Calvar 2014-02-19 01:16:59 PST 
Created attachment 224606 [details]
Patch
Comment 6 Xabier Rodríguez Calvar 2014-02-19 01:18:00 PST 
(In reply to comment #4)
> > +static unsigned getGstPlaysFlag(const char* nick)
> 
> Perhaps this could be moved to GStreamerUtilities

Done.

> >> +    GFlagsClass* flagsClass = static_cast<GFlagsClass*>(g_type_class_ref(g_type_from_name("GstPlayFlags")));
> > 
> > I was thinking of caching this by making it static. What do you think, Phil?
> 
> Ok but then no unref below I suppose :)

Of course, done.
Comment 7 WebKit Commit Bot 2014-02-19 02:19:50 PST 
Comment on attachment 224606 [details]
Patch

Clearing flags on attachment: 224606

Committed r164362: <http://trac.webkit.org/changeset/164362>
Comment 8 WebKit Commit Bot 2014-02-19 02:19:53 PST 
All reviewed patches have been landed.  Closing bug.