RESOLVED FIXED 128957
[GStreamer] the GstPlayFlags enum diverged from upstream 
https://bugs.webkit.org/show_bug.cgi?id=128957
Summary [GStreamer] the GstPlayFlags enum diverged from upstream
Philippe Normand
Reported 2014-02-17 23:40:09 PST
The GST_PLAY_FLAG_BUFFERING value is wrong now (how come?), the deinterlace and soft-colorbalance flags are missing.
Attachments
Patch (4.16 KB, patch)
2014-02-18 09:34 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2014-02-19 01:16 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2014-02-18 01:11:10 PST
This is going to be fun to support.
Xabier Rodríguez Calvar
Comment 2 2014-02-18 09:34:58 PST
Created attachment 224521 [details] Patch
Xabier Rodríguez Calvar
Comment 3 2014-02-18 09:36:02 PST
Comment on attachment 224521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224521&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:170 > + GFlagsClass* flagsClass = static_cast<GFlagsClass*>(g_type_class_ref(g_type_from_name("GstPlayFlags"))); I was thinking of caching this by making it static. What do you think, Phil?
Philippe Normand
Comment 4 2014-02-18 23:10:22 PST
Comment on attachment 224521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224521&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:168 > +static unsigned getGstPlaysFlag(const char* nick) Perhaps this could be moved to GStreamerUtilities >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:170 >> + GFlagsClass* flagsClass = static_cast<GFlagsClass*>(g_type_class_ref(g_type_from_name("GstPlayFlags"))); > > I was thinking of caching this by making it static. What do you think, Phil? Ok but then no unref below I suppose :)
Xabier Rodríguez Calvar
Comment 5 2014-02-19 01:16:59 PST
Created attachment 224606 [details] Patch
Xabier Rodríguez Calvar
Comment 6 2014-02-19 01:18:00 PST
(In reply to comment #4) > > +static unsigned getGstPlaysFlag(const char* nick) > > Perhaps this could be moved to GStreamerUtilities Done. > >> + GFlagsClass* flagsClass = static_cast<GFlagsClass*>(g_type_class_ref(g_type_from_name("GstPlayFlags"))); > > > > I was thinking of caching this by making it static. What do you think, Phil? > > Ok but then no unref below I suppose :) Of course, done.
WebKit Commit Bot
Comment 7 2014-02-19 02:19:50 PST
Comment on attachment 224606 [details] Patch Clearing flags on attachment: 224606 Committed r164362: <http://trac.webkit.org/changeset/164362>
WebKit Commit Bot
Comment 8 2014-02-19 02:19:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.