Bug 128957 - [GStreamer] the GstPlayFlags enum diverged from upstream
Summary: [GStreamer] the GstPlayFlags enum diverged from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-17 23:40 PST by Philippe Normand
Modified: 2014-02-19 02:19 PST (History)
12 users (show)

See Also:

Attachments
Patch (4.16 KB, patch)
2014-02-18 09:34 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2014-02-19 01:16 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2014-02-17 23:40:09 PST 
The GST_PLAY_FLAG_BUFFERING value is wrong now (how come?), the deinterlace and soft-colorbalance flags are missing.
Comment 1 Xabier Rodríguez Calvar 2014-02-18 01:11:10 PST 
This is going to be fun to support.
Comment 2 Xabier Rodríguez Calvar 2014-02-18 09:34:58 PST 
Created attachment 224521 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2014-02-18 09:36:02 PST 
Comment on attachment 224521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224521&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:170
> +    GFlagsClass* flagsClass = static_cast<GFlagsClass*>(g_type_class_ref(g_type_from_name("GstPlayFlags")));

I was thinking of caching this by making it static. What do you think, Phil?
Comment 4 Philippe Normand 2014-02-18 23:10:22 PST 
Comment on attachment 224521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224521&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:168
> +static unsigned getGstPlaysFlag(const char* nick)

Perhaps this could be moved to GStreamerUtilities

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:170
>> +    GFlagsClass* flagsClass = static_cast<GFlagsClass*>(g_type_class_ref(g_type_from_name("GstPlayFlags")));
> 
> I was thinking of caching this by making it static. What do you think, Phil?

Ok but then no unref below I suppose :)
Comment 5 Xabier Rodríguez Calvar 2014-02-19 01:16:59 PST 
Created attachment 224606 [details]
Patch
Comment 6 Xabier Rodríguez Calvar 2014-02-19 01:18:00 PST 
(In reply to comment #4)
> > +static unsigned getGstPlaysFlag(const char* nick)
> 
> Perhaps this could be moved to GStreamerUtilities

Done.

> >> +    GFlagsClass* flagsClass = static_cast<GFlagsClass*>(g_type_class_ref(g_type_from_name("GstPlayFlags")));
> > 
> > I was thinking of caching this by making it static. What do you think, Phil?
> 
> Ok but then no unref below I suppose :)

Of course, done.
Comment 7 WebKit Commit Bot 2014-02-19 02:19:50 PST 
Comment on attachment 224606 [details]
Patch

Clearing flags on attachment: 224606

Committed r164362: <http://trac.webkit.org/changeset/164362>
Comment 8 WebKit Commit Bot 2014-02-19 02:19:53 PST 
All reviewed patches have been landed.  Closing bug.