Bug 128914

Summary: [CSS Regions] Move specific named flow methods from RenderRegion to RenderNamedFlowFragment
Product: WebKit Reporter: Radu Stavila <stavila>
Component: CSSAssignee: Radu Stavila <stavila>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
koivisto: review+
Patch integrating feedback
none
Rebase none

Description Radu Stavila 2014-02-17 09:19:34 PST 
Move the regionContainer and regionContainerLayer methods from RenderRegion to RenderNamedFlowFragment
Comment 1 Radu Stavila 2014-02-17 14:19:45 PST 
Created attachment 224423 [details]
Patch
Comment 2 Antti Koivisto 2014-02-17 14:23:05 PST 
Comment on attachment 224423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224423&action=review

r=me

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:195
> +RenderBlockFlow* RenderNamedFlowFragment::fragmentContainer() const
> +{
> +    ASSERT(parent() && parent()->isRenderNamedFlowFragmentContainer());
> +    return toRenderBlockFlow(parent());
> +}

Looks like this is never null. Could you return a reference?

Please assert the conditions separately (makes seeing what failed easier).

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:200
> +RenderLayer* RenderNamedFlowFragment::fragmentContainerLayer() const
> +{
> +    return fragmentContainer()->layer();
> +}

Can this be null?
Comment 3 Radu Stavila 2014-02-17 14:41:16 PST 
Created attachment 224425 [details]
Patch integrating feedback
Comment 4 Radu Stavila 2014-02-17 15:44:12 PST 
Created attachment 224441 [details]
Rebase
Comment 5 WebKit Commit Bot 2014-02-17 23:48:38 PST 
Comment on attachment 224441 [details]
Rebase

Clearing flags on attachment: 224441

Committed r164275: <http://trac.webkit.org/changeset/164275>