Bug 128914 – [CSS Regions] Move specific named flow methods from RenderRegion to RenderNamedFlowFragment

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Radu Stavila]

Move the regionContainer and regionContainerLayer methods from RenderRegion to RenderNamedFlowFragment

[Radu Stavila]

Created attachment 224423 [details]
Patch

[Antti Koivisto]

Comment on attachment 224423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224423&action=review

r=me

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:195
> +RenderBlockFlow* RenderNamedFlowFragment::fragmentContainer() const
> +{
> +    ASSERT(parent() && parent()->isRenderNamedFlowFragmentContainer());
> +    return toRenderBlockFlow(parent());
> +}

Looks like this is never null. Could you return a reference?

Please assert the conditions separately (makes seeing what failed easier).

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:200
> +RenderLayer* RenderNamedFlowFragment::fragmentContainerLayer() const
> +{
> +    return fragmentContainer()->layer();
> +}

Can this be null?

[Radu Stavila]

Created attachment 224425 [details]
Patch integrating feedback

[Radu Stavila]

Created attachment 224441 [details]
Rebase

[WebKit Commit Bot]

Comment on attachment 224441 [details]
Rebase

Clearing flags on attachment: 224441

Committed r164275: <http://trac.webkit.org/changeset/164275>