Bug 128912

Summary: Move back primary header includes next to config.h
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2014-02-17 08:13:34 PST
http://trac.webkit.org/changeset/163760 " Never include *Inlines.h files in interface headers, and never include *Inlines.h when you could include Operations.h instead" This changeset moved many primary header inclusion after the #if ENABLE(...) guard without any profit and added zillion webkit style violations pointlessly. The discussion started about it in the original bug report: https://bugs.webkit.org/show_bug.cgi?id=128505#c26 original code was ------------------ #include "config.h" #include "Blah.h" #if ENABLE(...) new code is: ------------- #include "config.h" #if ENABLE(...) #include "Blah.h" -------------------------------------------------------------------------------------- It was a false presumption if this kind of change fixed the EFL build, because ENABLE(JIT) and ENABLE(DFG_JIT) are always true on EFL. Additionally almost all of these headers are guarded properly, we really don't need one more guard for the include. I'm going to revert this unrelated noise.
Attachments
Patch (61.79 KB, patch)
2014-02-17 08:16 PST, Csaba Osztrogonác
no flags
Csaba Osztrogonác
Comment 1 2014-02-17 08:16:26 PST
Csaba Osztrogonác
Comment 2 2014-02-17 08:18:47 PST
Additionally it doesn't affect the DFG and the non-DFG builds ( after non-DFG build is fixed in Source/JavaScriptCore/jit/Repatch.cpp once in bug128549 )
WebKit Commit Bot
Comment 3 2014-02-17 10:54:51 PST
Comment on attachment 224371 [details] Patch Clearing flags on attachment: 224371 Committed r164229: <http://trac.webkit.org/changeset/164229>
WebKit Commit Bot
Comment 4 2014-02-17 10:54:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.