Bug 128899

Summary: CLoop buildfix after r164207
Product: WebKit Reporter: Dániel Bátyai <dbatyai.u-szeged>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, oliver, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128795    
Attachments:
Description Flags
Proposed fix none

Dániel Bátyai
Reported 2014-02-17 04:28:17 PST
In file included from /Volumes/Data/slave/mavericks-cloop-debug/build/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:29: In file included from /Volumes/Data/slave/mavericks-cloop-debug/build/Source/JavaScriptCore/bytecode/CodeBlock.h:45: /Volumes/Data/slave/mavericks-cloop-debug/build/Source/JavaScriptCore/dfg/DFGCommon.h:293:51: error: unused parameter 'mode' [-Werror,-Wunused-parameter] inline bool shouldShowDisassembly(CompilationMode mode = DFGMode) ^ 1 error generated.
Attachments
Proposed fix (1.04 KB, patch)
2014-02-17 04:29 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dániel Bátyai
Comment 1 2014-02-17 04:29:22 PST
Created attachment 224356 [details] Proposed fix
Csaba Osztrogonác
Comment 2 2014-02-17 04:31:23 PST
Comment on attachment 224356 [details] Proposed fix LGTM, r=me
WebKit Commit Bot
Comment 3 2014-02-17 05:09:34 PST
Comment on attachment 224356 [details] Proposed fix Clearing flags on attachment: 224356 Committed r164216: <http://trac.webkit.org/changeset/164216>
WebKit Commit Bot
Comment 4 2014-02-17 05:09:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.