Bug 128891

Summary: Move PublicManager to std::unique_ptr
Product: WebKit Reporter: Sangho Kim <thomas.kim>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, gyuyoung.kim, jer.noble, kangil.han, pnormand, sun.shin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
new patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Sangho Kim 2014-02-16 22:55:02 PST
We should move PassOwnPtr to std::unique_ptr<>.
Comment 1 Sangho Kim 2014-02-16 23:12:53 PST
Created attachment 224333 [details]
patch

Use std::unique_ptr and std::make_unique in place of PassOwnPtr and adoptPtr in the PublicURLManager
Comment 2 WebKit Commit Bot 2014-02-16 23:14:09 PST
Attachment 224333 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sangho Kim 2014-02-16 23:20:19 PST
Created attachment 224336 [details]
new patch

change ChangeLog
Comment 4 Sangho Kim 2014-02-16 23:40:32 PST
Created attachment 224337 [details]
Patch
Comment 5 Sangho Kim 2014-02-17 00:20:14 PST
Created attachment 224339 [details]
Patch
Comment 6 Sangho Kim 2014-02-17 01:21:28 PST
Created attachment 224341 [details]
Patch
Comment 7 Anders Carlsson 2014-02-17 07:13:56 PST
Comment on attachment 224341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224341&action=review

> Source/WebCore/html/PublicURLManager.h:47
> +    PublicURLManager(ScriptExecutionContext*);

Please make this explicit.
Comment 8 Sangho Kim 2014-02-17 15:07:39 PST
Created attachment 224430 [details]
Patch
Comment 9 WebKit Commit Bot 2014-02-17 23:12:12 PST
Comment on attachment 224430 [details]
Patch

Clearing flags on attachment: 224430

Committed r164274: <http://trac.webkit.org/changeset/164274>
Comment 10 WebKit Commit Bot 2014-02-17 23:12:15 PST
All reviewed patches have been landed.  Closing bug.