Summary: | Move PublicManager to std::unique_ptr | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sangho Kim <thomas.kim> | ||||||||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, gyuyoung.kim, jer.noble, kangil.han, pnormand, sun.shin | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Sangho Kim
2014-02-16 22:55:02 PST
Created attachment 224333 [details]
patch
Use std::unique_ptr and std::make_unique in place of PassOwnPtr and adoptPtr in the PublicURLManager
Attachment 224333 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 224336 [details]
new patch
change ChangeLog
Created attachment 224337 [details]
Patch
Created attachment 224339 [details]
Patch
Created attachment 224341 [details]
Patch
Comment on attachment 224341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224341&action=review > Source/WebCore/html/PublicURLManager.h:47 > + PublicURLManager(ScriptExecutionContext*); Please make this explicit. Created attachment 224430 [details]
Patch
Comment on attachment 224430 [details] Patch Clearing flags on attachment: 224430 Committed r164274: <http://trac.webkit.org/changeset/164274> All reviewed patches have been landed. Closing bug. |