Bug 128891 - Move PublicManager to std::unique_ptr
Summary: Move PublicManager to std::unique_ptr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-16 22:55 PST by Sangho Kim
Modified: 2014-02-17 23:12 PST (History)
7 users (show)

See Also:

Attachments
patch (2.29 KB, application/octet-stream)
2014-02-16 23:12 PST, Sangho Kim 		no flags Details
new patch (2.25 KB, application/octet-stream)
2014-02-16 23:20 PST, Sangho Kim 		no flags Details
Patch (2.48 KB, patch)
2014-02-16 23:40 PST, Sangho Kim 		no flags Details | Formatted Diff | Diff
Patch (3.11 KB, patch)
2014-02-17 00:20 PST, Sangho Kim 		no flags Details | Formatted Diff | Diff
Patch (3.41 KB, patch)
2014-02-17 01:21 PST, Sangho Kim 		no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2014-02-17 15:07 PST, Sangho Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sangho Kim 2014-02-16 22:55:02 PST 
We should move PassOwnPtr to std::unique_ptr<>.
Comment 1 Sangho Kim 2014-02-16 23:12:53 PST 
Created attachment 224333 [details]
patch

Use std::unique_ptr and std::make_unique in place of PassOwnPtr and adoptPtr in the PublicURLManager
Comment 2 WebKit Commit Bot 2014-02-16 23:14:09 PST 
Attachment 224333 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sangho Kim 2014-02-16 23:20:19 PST 
Created attachment 224336 [details]
new patch

change ChangeLog
Comment 4 Sangho Kim 2014-02-16 23:40:32 PST 
Created attachment 224337 [details]
Patch
Comment 5 Sangho Kim 2014-02-17 00:20:14 PST 
Created attachment 224339 [details]
Patch
Comment 6 Sangho Kim 2014-02-17 01:21:28 PST 
Created attachment 224341 [details]
Patch
Comment 7 Anders Carlsson 2014-02-17 07:13:56 PST 
Comment on attachment 224341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224341&action=review

> Source/WebCore/html/PublicURLManager.h:47
> +    PublicURLManager(ScriptExecutionContext*);

Please make this explicit.
Comment 8 Sangho Kim 2014-02-17 15:07:39 PST 
Created attachment 224430 [details]
Patch
Comment 9 WebKit Commit Bot 2014-02-17 23:12:12 PST 
Comment on attachment 224430 [details]
Patch

Clearing flags on attachment: 224430

Committed r164274: <http://trac.webkit.org/changeset/164274>
Comment 10 WebKit Commit Bot 2014-02-17 23:12:15 PST 
All reviewed patches have been landed.  Closing bug.